* [PATCH] serial: 8250_dw: Add device HID for new AMD UART controller
@ 2021-05-12 21:04 Maximilian Luz
2021-05-13 7:08 ` Andy Shevchenko
2021-05-17 15:01 ` Rafael J. Wysocki
0 siblings, 2 replies; 4+ messages in thread
From: Maximilian Luz @ 2021-05-12 21:04 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Maximilian Luz, Jiri Slaby, Rafael J. Wysocki, Len Brown,
Andy Shevchenko, linux-acpi, linux-kernel, linux-serial, stable,
Sachi King
Add device HID AMDI0022 to the AMD UART controller driver match table
and create a platform device for it. This controller can be found on
Microsoft Surface Laptop 4 devices and seems similar enough that we can
just copy the existing AMDI0020 entries.
Cc: <stable@vger.kernel.org> # 5.10+
Tested-by: Sachi King <nakato@nakato.io>
Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
---
drivers/acpi/acpi_apd.c | 1 +
drivers/tty/serial/8250/8250_dw.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
index 0ec5b3f69112..6e02448d15d9 100644
--- a/drivers/acpi/acpi_apd.c
+++ b/drivers/acpi/acpi_apd.c
@@ -226,6 +226,7 @@ static const struct acpi_device_id acpi_apd_device_ids[] = {
{ "AMDI0010", APD_ADDR(wt_i2c_desc) },
{ "AMD0020", APD_ADDR(cz_uart_desc) },
{ "AMDI0020", APD_ADDR(cz_uart_desc) },
+ { "AMDI0022", APD_ADDR(cz_uart_desc) },
{ "AMD0030", },
{ "AMD0040", APD_ADDR(fch_misc_desc)},
{ "HYGO0010", APD_ADDR(wt_i2c_desc) },
diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
index 9e204f9b799a..a3a0154da567 100644
--- a/drivers/tty/serial/8250/8250_dw.c
+++ b/drivers/tty/serial/8250/8250_dw.c
@@ -714,6 +714,7 @@ static const struct acpi_device_id dw8250_acpi_match[] = {
{ "APMC0D08", 0},
{ "AMD0020", 0 },
{ "AMDI0020", 0 },
+ { "AMDI0022", 0 },
{ "BRCM2032", 0 },
{ "HISI0031", 0 },
{ },
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] serial: 8250_dw: Add device HID for new AMD UART controller
2021-05-12 21:04 [PATCH] serial: 8250_dw: Add device HID for new AMD UART controller Maximilian Luz
@ 2021-05-13 7:08 ` Andy Shevchenko
2021-05-17 15:01 ` Rafael J. Wysocki
1 sibling, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2021-05-13 7:08 UTC (permalink / raw)
To: Maximilian Luz
Cc: Greg Kroah-Hartman, Jiri Slaby, Rafael J. Wysocki, Len Brown,
Andy Shevchenko, linux-acpi, linux-kernel, linux-serial, stable,
Sachi King
On Thu, May 13, 2021 at 1:20 AM Maximilian Luz <luzmaximilian@gmail.com> wrote:
>
> Add device HID AMDI0022 to the AMD UART controller driver match table
> and create a platform device for it. This controller can be found on
> Microsoft Surface Laptop 4 devices and seems similar enough that we can
> just copy the existing AMDI0020 entries.
Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com> # for 8250_dw part
> Cc: <stable@vger.kernel.org> # 5.10+
> Tested-by: Sachi King <nakato@nakato.io>
> Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
> ---
> drivers/acpi/acpi_apd.c | 1 +
> drivers/tty/serial/8250/8250_dw.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
> index 0ec5b3f69112..6e02448d15d9 100644
> --- a/drivers/acpi/acpi_apd.c
> +++ b/drivers/acpi/acpi_apd.c
> @@ -226,6 +226,7 @@ static const struct acpi_device_id acpi_apd_device_ids[] = {
> { "AMDI0010", APD_ADDR(wt_i2c_desc) },
> { "AMD0020", APD_ADDR(cz_uart_desc) },
> { "AMDI0020", APD_ADDR(cz_uart_desc) },
> + { "AMDI0022", APD_ADDR(cz_uart_desc) },
> { "AMD0030", },
> { "AMD0040", APD_ADDR(fch_misc_desc)},
> { "HYGO0010", APD_ADDR(wt_i2c_desc) },
> diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
> index 9e204f9b799a..a3a0154da567 100644
> --- a/drivers/tty/serial/8250/8250_dw.c
> +++ b/drivers/tty/serial/8250/8250_dw.c
> @@ -714,6 +714,7 @@ static const struct acpi_device_id dw8250_acpi_match[] = {
> { "APMC0D08", 0},
> { "AMD0020", 0 },
> { "AMDI0020", 0 },
> + { "AMDI0022", 0 },
> { "BRCM2032", 0 },
> { "HISI0031", 0 },
> { },
> --
> 2.31.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] serial: 8250_dw: Add device HID for new AMD UART controller
2021-05-12 21:04 [PATCH] serial: 8250_dw: Add device HID for new AMD UART controller Maximilian Luz
2021-05-13 7:08 ` Andy Shevchenko
@ 2021-05-17 15:01 ` Rafael J. Wysocki
2021-05-17 15:57 ` Greg Kroah-Hartman
1 sibling, 1 reply; 4+ messages in thread
From: Rafael J. Wysocki @ 2021-05-17 15:01 UTC (permalink / raw)
To: Maximilian Luz
Cc: Greg Kroah-Hartman, Jiri Slaby, Rafael J. Wysocki, Len Brown,
Andy Shevchenko, ACPI Devel Maling List,
Linux Kernel Mailing List, linux-serial, Stable, Sachi King
On Thu, May 13, 2021 at 12:25 AM Maximilian Luz <luzmaximilian@gmail.com> wrote:
>
> Add device HID AMDI0022 to the AMD UART controller driver match table
> and create a platform device for it. This controller can be found on
> Microsoft Surface Laptop 4 devices and seems similar enough that we can
> just copy the existing AMDI0020 entries.
>
> Cc: <stable@vger.kernel.org> # 5.10+
> Tested-by: Sachi King <nakato@nakato.io>
> Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
or please let me know if this needs to go in through ACPI (I'm
assuming that it doesn't).
> ---
> drivers/acpi/acpi_apd.c | 1 +
> drivers/tty/serial/8250/8250_dw.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
> index 0ec5b3f69112..6e02448d15d9 100644
> --- a/drivers/acpi/acpi_apd.c
> +++ b/drivers/acpi/acpi_apd.c
> @@ -226,6 +226,7 @@ static const struct acpi_device_id acpi_apd_device_ids[] = {
> { "AMDI0010", APD_ADDR(wt_i2c_desc) },
> { "AMD0020", APD_ADDR(cz_uart_desc) },
> { "AMDI0020", APD_ADDR(cz_uart_desc) },
> + { "AMDI0022", APD_ADDR(cz_uart_desc) },
> { "AMD0030", },
> { "AMD0040", APD_ADDR(fch_misc_desc)},
> { "HYGO0010", APD_ADDR(wt_i2c_desc) },
> diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
> index 9e204f9b799a..a3a0154da567 100644
> --- a/drivers/tty/serial/8250/8250_dw.c
> +++ b/drivers/tty/serial/8250/8250_dw.c
> @@ -714,6 +714,7 @@ static const struct acpi_device_id dw8250_acpi_match[] = {
> { "APMC0D08", 0},
> { "AMD0020", 0 },
> { "AMDI0020", 0 },
> + { "AMDI0022", 0 },
> { "BRCM2032", 0 },
> { "HISI0031", 0 },
> { },
> --
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] serial: 8250_dw: Add device HID for new AMD UART controller
2021-05-17 15:01 ` Rafael J. Wysocki
@ 2021-05-17 15:57 ` Greg Kroah-Hartman
0 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2021-05-17 15:57 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Maximilian Luz, Jiri Slaby, Rafael J. Wysocki, Len Brown,
Andy Shevchenko, ACPI Devel Maling List,
Linux Kernel Mailing List, linux-serial, Stable, Sachi King
On Mon, May 17, 2021 at 05:01:15PM +0200, Rafael J. Wysocki wrote:
> On Thu, May 13, 2021 at 12:25 AM Maximilian Luz <luzmaximilian@gmail.com> wrote:
> >
> > Add device HID AMDI0022 to the AMD UART controller driver match table
> > and create a platform device for it. This controller can be found on
> > Microsoft Surface Laptop 4 devices and seems similar enough that we can
> > just copy the existing AMDI0020 entries.
> >
> > Cc: <stable@vger.kernel.org> # 5.10+
> > Tested-by: Sachi King <nakato@nakato.io>
> > Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
>
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> or please let me know if this needs to go in through ACPI (I'm
> assuming that it doesn't).
I've already taken it in my tty tree :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-17 16:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-12 21:04 [PATCH] serial: 8250_dw: Add device HID for new AMD UART controller Maximilian Luz
2021-05-13 7:08 ` Andy Shevchenko
2021-05-17 15:01 ` Rafael J. Wysocki
2021-05-17 15:57 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).