From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A914C43460 for ; Tue, 18 May 2021 12:39:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6CD3B6108B for ; Tue, 18 May 2021 12:39:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349254AbhERMlE (ORCPT ); Tue, 18 May 2021 08:41:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:60242 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241412AbhERMlD (ORCPT ); Tue, 18 May 2021 08:41:03 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4DDCF61185; Tue, 18 May 2021 12:39:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621341585; bh=F2UdS6cLiN/LZ0pqKzAK2trMNWftL6aAnrLJ9ytG5EI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jpiuHKlOjeWqXsf9DWXnvo9i0IwSHaUZ5m3CVNrBp6qXyHV3RG6w0f2jXxkrxDkXK 0qnIgATxk3R6HRSHyb2+vpzHn9sdPv+JtvZhJ59TSFB9VGKAHZRG7Kgcnu7hmQ9qLn VVvU8E2Vm/KknEGwuZOAV9fTz4jL168H2+H4UFMk= Date: Tue, 18 May 2021 14:39:43 +0200 From: Greg Kroah-Hartman To: Rudi Heitbaum Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Florian Fainelli , Vladimir Oltean , "David S. Miller" , Sasha Levin Subject: Re: [PATCH 5.12 081/363] net: bridge: propagate error code and extack from br_mc_disabled_update Message-ID: References: <20210517140302.508966430@linuxfoundation.org> <20210517140305.339768334@linuxfoundation.org> <20210518122449.GA65@ec3d6f83b95b> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210518122449.GA65@ec3d6f83b95b> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 18, 2021 at 12:24:57PM +0000, Rudi Heitbaum wrote: > On Mon, May 17, 2021 at 03:59:07PM +0200, Greg Kroah-Hartman wrote: > > From: Florian Fainelli > > > > [ Upstream commit ae1ea84b33dab45c7b6c1754231ebda5959b504c ] > > > > Some Ethernet switches might only be able to support disabling multicast > > snooping globally, which is an issue for example when several bridges > > span the same physical device and request contradictory settings. > > > > Propagate the return value of br_mc_disabled_update() such that this > > limitation is transmitted correctly to user-space. > > > > Signed-off-by: Florian Fainelli > > Signed-off-by: Vladimir Oltean > > Signed-off-by: David S. Miller > > Signed-off-by: Sasha Levin > > --- > > net/bridge/br_multicast.c | 28 +++++++++++++++++++++------- > > net/bridge/br_netlink.c | 4 +++- > > net/bridge/br_private.h | 3 ++- > > net/bridge/br_sysfs_br.c | 8 +------- > > 4 files changed, 27 insertions(+), 16 deletions(-) > > This patch results in docker failing to start, and a regression between > 5.12.4 and 5.12.5-rc1 > > A working dmesg output is like: > > [ 11.545255] device eth0 entered promiscuous mode > [ 11.693848] process 'docker/tmp/qemu-check643160757/check' started with executable stack > [ 17.233059] br-92020c7e3aea: port 1(veth17a0552) entered blocking state > [ 17.233065] br-92020c7e3aea: port 1(veth17a0552) entered disabled state > [ 17.233098] device veth17a0552 entered promiscuous mode > [ 17.292839] docker0: port 2(veth9d227f5) entered blocking state > [ 17.292848] docker0: port 2(veth9d227f5) entered disabled state > [ 17.292946] device veth9d227f5 entered promiscuous mode > [ 17.293070] docker0: port 2(veth9d227f5) entered blocking state > [ 17.293075] docker0: port 2(veth9d227f5) entered forwarding state > > with this patch "device veth17a0552 entered promiscuous mode" never > shows up. > > the docker error itself is: > > docker: Error response from daemon: failed to create endpoint > sleepy_dijkstra on network bridge: adding interface veth8cbd8f9 to > bridge docker0 failed: operation not supported. Ick. Does 5.13-rc1 also show this same problem? And thanks for testing! greg k-h