From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEAD9C433ED for ; Tue, 18 May 2021 16:30:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D2135611CE for ; Tue, 18 May 2021 16:30:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350655AbhERQbx (ORCPT ); Tue, 18 May 2021 12:31:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:33984 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237653AbhERQbq (ORCPT ); Tue, 18 May 2021 12:31:46 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D6C07610E9; Tue, 18 May 2021 16:30:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621355428; bh=4ZBRrXcWPCCVuVPJ6n2VmLfCXKEO/hfmErEmuYLiqYg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rhI4WS+UO/sZkToGAtj/hM5uQPgOBn3jhrRhSDN3AVke6J8j2xrDIxDcSqLplA9/c /4xLttZwGMYmz3e7/EL9hJ1YVycfGjoyLpv9x0wyJobFj6KLTyk02E3yqAS6ClYLCY +ouIuKf4PX5xh1alLeVA8H0ej9gHuGuLNYcKq48Y= Date: Tue, 18 May 2021 18:30:26 +0200 From: Greg Kroah-Hartman To: linux-wireless@vger.kernel.org Cc: Larry Finger , Kalle Valo , "David S. Miller" , Jakub Kicinski , b43-dev@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 8/9] b43legacy: don't save dentries for debugfs Message-ID: References: <20210518162805.3700405-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210518162805.3700405-1-gregkh@linuxfoundation.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 18, 2021 at 06:28:05PM +0200, Greg Kroah-Hartman wrote: > There is no need to keep around the dentry pointers for the debugfs > files as they will all be automatically removed when the subdir is > removed. So save the space and logic involved in keeping them around by > just getting rid of them entirely. > > By doing this change, we remove one of the last in-kernel user that was > storing the result of debugfs_create_bool(), so that api can be cleaned > up. > > Cc: Larry Finger > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: linux-wireless@vger.kernel.org > Cc: b43-dev@lists.infradead.org > Cc: netdev@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman > --- > .../net/wireless/broadcom/b43legacy/debugfs.c | 29 ++++--------------- > .../net/wireless/broadcom/b43legacy/debugfs.h | 3 -- > 2 files changed, 5 insertions(+), 27 deletions(-) Got the subject wrong, will resend...