From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42C53C43460 for ; Wed, 19 May 2021 01:25:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 241AF61369 for ; Wed, 19 May 2021 01:25:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232689AbhESB1A (ORCPT ); Tue, 18 May 2021 21:27:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231689AbhESB07 (ORCPT ); Tue, 18 May 2021 21:26:59 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 909BBC06175F; Tue, 18 May 2021 18:25:40 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8C23145E; Wed, 19 May 2021 03:25:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1621387537; bh=ElhwxGKUwEWUYDnidWAaBFEhwLU8MhQqllbbZ9/wkKI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gx0CQwuofTPcFArYqtsSSbVjGJZTeqg9V0NbRhVwIixE55pSFeInAiwv0ZCQjbVY+ ViiwvDXYi4RDEvVxWUXqMixKeXq/scVReHZBTWt2xzqfGGEzUSdOJtN54Ka6El8nlm 0qPqOp30KfU9FSNFFHkfK+hoZzPkvfjYA3cKf1r4= Date: Wed, 19 May 2021 04:25:36 +0300 From: Laurent Pinchart To: Rob Herring Cc: devicetree@vger.kernel.org, Peter Rosin , Wolfram Sang , linux-kernel@vger.kernel.org, Alexandre Belloni , Jacopo Mondi , Kieran Bingham , Kishon Vijay Abraham I , Lee Jones , Niklas =?utf-8?Q?S=C3=B6derlund?= , Roger Quadros , Jonathan Cameron Subject: Re: [PATCH 2/6] dt-bindings: rtc: nxp,pcf8563: Convert to DT schema Message-ID: References: <20210518232858.1535403-1-robh@kernel.org> <20210518232858.1535403-3-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210518232858.1535403-3-robh@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, Thank you for the patch. On Tue, May 18, 2021 at 06:28:54PM -0500, Rob Herring wrote: > Convert the Philips PCF8563/Epson RTC8564 binding to DT schema format. > > Add 'interrupts' as this device has an interrupt which was not > documented, but in use. > > Cc: Alexandre Belloni > Signed-off-by: Rob Herring Reviewed-by: Laurent Pinchart > --- > .../devicetree/bindings/rtc/nxp,pcf8563.yaml | 50 +++++++++++++++++++ > .../devicetree/bindings/rtc/pcf8563.txt | 29 ----------- > 2 files changed, 50 insertions(+), 29 deletions(-) > create mode 100644 Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml > delete mode 100644 Documentation/devicetree/bindings/rtc/pcf8563.txt > > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml > new file mode 100644 > index 000000000000..15e67be0ef95 > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml > @@ -0,0 +1,50 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/rtc/nxp,pcf8563.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Philips PCF8563/Epson RTC8564 Real Time Clock > + > +maintainers: > + - Alexandre Belloni > + > +properties: > + compatible: > + enum: > + - epson,rtc8564 > + - microcrystal,rv8564 > + - nxp,pcf8563 > + - nxp,pca8565 > + > + reg: > + maxItems: 1 > + > + "#clock-cells": > + const: 0 > + > + clock-output-names: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + rtc@51 { > + compatible = "nxp,pcf8563"; > + reg = <0x51>; > + #clock-cells = <0>; > + }; > + }; > +... > diff --git a/Documentation/devicetree/bindings/rtc/pcf8563.txt b/Documentation/devicetree/bindings/rtc/pcf8563.txt > deleted file mode 100644 > index 0a900f7c8977..000000000000 > --- a/Documentation/devicetree/bindings/rtc/pcf8563.txt > +++ /dev/null > @@ -1,29 +0,0 @@ > -* Philips PCF8563/Epson RTC8564 Real Time Clock > - > -Philips PCF8563/Epson RTC8564 Real Time Clock > - > -Required properties: > -- compatible: Should contain "nxp,pcf8563", > - "epson,rtc8564" or > - "microcrystal,rv8564" or > - "nxp,pca8565" > -- reg: I2C address for chip. > - > -Optional property: > -- #clock-cells: Should be 0. > -- clock-output-names: > - overwrite the default clock name "pcf8563-clkout" > - > -Example: > - > -pcf8563: pcf8563@51 { > - compatible = "nxp,pcf8563"; > - reg = <0x51>; > - #clock-cells = <0>; > -}; > - > -device { > -... > - clocks = <&pcf8563>; > -... > -}; -- Regards, Laurent Pinchart