From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jeff Johnson <jjohnson@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Kees Cook <keescook@chromium.org>, Jason Gunthorpe <jgg@ziepe.ca>,
Chao Yu <chao@kernel.org>, Leon Romanovsky <leon@kernel.org>,
b43-dev@lists.infradead.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
jjohnson=codeaurora.org@codeaurora.org
Subject: Re: [PATCH v2] b43: don't save dentries for debugfs
Date: Wed, 19 May 2021 18:03:08 +0200 [thread overview]
Message-ID: <YKU2vMoDO0Ch1Lyg@kroah.com> (raw)
In-Reply-To: <48aea7ae33faaafab388e24c3b8eb199@codeaurora.org>
On Wed, May 19, 2021 at 08:57:00AM -0700, Jeff Johnson wrote:
> On 2021-05-19 08:42, Greg Kroah-Hartman wrote:
> > On Wed, May 19, 2021 at 08:04:59AM -0700, Jeff Johnson wrote:
> > > On 2021-05-18 22:05, Greg Kroah-Hartman wrote:
> > > > On Tue, May 18, 2021 at 03:00:44PM -0700, Jeff Johnson wrote:
> > > > > On 2021-05-18 12:29, Jeff Johnson wrote:
> > > > > Would still like guidance on if there is a recommended way to get a
> > > > > dentry not associated with debugfs.
> > > >
> > > > What do you exactly mean by "not associated with debugfs"?
> > > >
> > > > And why are you passing a debugfs dentry to relay_open()? That feels
> > > > really wrong and fragile.
> > >
> > > I don't know the history but the relay documentation tells us:
> > > "If you want a directory structure to contain your relay files,
> > > you should create it using the host filesystem’s directory
> > > creation function, e.g. debugfs_create_dir()..."
> > >
> > > So my guess is that the original implementation followed that
> > > advice. I see 5 clients of this functionality, and all 5 pass a
> > > dentry returned from debugfs_create_dir():
> > >
> > > drivers/gpu/drm/i915/gt/uc/intel_guc_log.c, line 384
> > > drivers/net/wireless/ath/ath10k/spectral.c, line 534
> > > drivers/net/wireless/ath/ath11k/spectral.c, line 902
> > > drivers/net/wireless/ath/ath9k/common-spectral.c, line 1077
> > > kernel/trace/blktrace.c, line 549
> >
> > Ah, that's just the "parent" dentry for the relayfs file. That's fine,
> > not a big deal, debugfs will always provide a way for you to get that if
> > needed.
>
> Unless debugfs is disabled, like on Android, which is the real problem I'm
> trying to solve.
Then use some other filesystem to place your relay file in. A relay
file is not a file that userspace should rely on for normal operation,
so why do you need it at all?
What tools/operation requires access to this file that systems without
debugfs support is causing problems on?
thanks,
greg k-h
prev parent reply other threads:[~2021-05-19 16:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 16:33 [PATCH v2] b43: don't save dentries for debugfs Greg Kroah-Hartman
2021-05-18 17:47 ` Kalle Valo
2021-05-21 18:44 ` Greg Kroah-Hartman
2021-05-18 19:29 ` Jeff Johnson
2021-05-18 22:00 ` Jeff Johnson
2021-05-19 5:05 ` Greg Kroah-Hartman
2021-05-19 15:04 ` Jeff Johnson
2021-05-19 15:42 ` Greg Kroah-Hartman
2021-05-19 15:57 ` Jeff Johnson
2021-05-19 16:03 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKU2vMoDO0Ch1Lyg@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=b43-dev@lists.infradead.org \
--cc=chao@kernel.org \
--cc=davem@davemloft.net \
--cc=jgg@ziepe.ca \
--cc=jjohnson=codeaurora.org@codeaurora.org \
--cc=jjohnson@codeaurora.org \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).