From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7C39C43460 for ; Thu, 20 May 2021 17:14:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D6F7610CB for ; Thu, 20 May 2021 17:14:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232984AbhETRP1 (ORCPT ); Thu, 20 May 2021 13:15:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231730AbhETRPY (ORCPT ); Thu, 20 May 2021 13:15:24 -0400 Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B39EC061574; Thu, 20 May 2021 10:14:01 -0700 (PDT) Received: by mail-qk1-x733.google.com with SMTP id i67so16926810qkc.4; Thu, 20 May 2021 10:14:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=jq3RYlVbDqirRaEWm8uYC1ns+MqjwZOrxQ2cNaYJlDg=; b=RcqLGnRn4lP6HGnhbtHRODna8BfZi+cQ75Ojh1B4T/MQoZSyXe2wIId8LU/kqGA7RM Jp1XZ8pXeszuDXG2zHzwpmNEWdzYkAqLorKBiBofI+lWWUy9ou5hlBCb/00XqAx7VGqX B2nUQXfsNTC0+7l1GVDhg99kfLgOkyzkrIu2GHZp+5/U4nrOe9v+sKXA4Rrh1IRQs5NC TtjfKt0OJKP+qzmj623o4ETkBwevelOVGwy/nGA4p61DCshVyCcWWdEIZ1L+DULfysEX oUOHMtklqm/ZpQ4LRNJj968x5SDD3XYUmYrQljJeJOO9Y3Z+bNBNtPqjnJ2CuJySJs24 6yZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jq3RYlVbDqirRaEWm8uYC1ns+MqjwZOrxQ2cNaYJlDg=; b=dsICxuT99/hCXoElAdGM3dyegCt+4kQ2YozJQDCCgxFCc6CBOyLPja3UC0eUKAX19U 9zvevYKSumHVswlv0/Q+tZZgL+8UpmUp9/N9eoc3rn7GSVzdNdNJVaGd9+rDzNCuFU1z 7jReg53nkgEm7Mu/QwfoIOyN9sQZo+XPf6FNDK0VvqSvPydlL7u7UfSnZfEf6FefXxUg fJYM4xIjmjmTx6fhNW10OYrdQz1u1bv2H8AC4MJftoYOTKZCfN3H5RcH2ucqb6xBu4Bd fzicNLyrFyt7G3CxBo8ypdkOg5/Pmta275KFCefXhYui0/u0GhkAroywc7jr5mnXWyf+ rnOg== X-Gm-Message-State: AOAM532UMSvN3Eu5I4GnY5pqmYAjVrGAWeJFbWabFC2EoZGhYD0L0vJU XIrgmstgZ25Tg7umJyppcVs= X-Google-Smtp-Source: ABdhPJyYWtKsmIPSoSGsuqdD6zSwDOtYPVRAqi9Swk/0eu3dTFJS9AZQooo4mifGsrIHWJWHudqfBw== X-Received: by 2002:a37:93c2:: with SMTP id v185mr6435183qkd.179.1621530840751; Thu, 20 May 2021 10:14:00 -0700 (PDT) Received: from smtp.gmail.com ([2804:30c:b19:6700:15d6:7f1d:c87:ccf7]) by smtp.gmail.com with ESMTPSA id f127sm2462842qkd.81.2021.05.20.10.13.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 May 2021 10:14:00 -0700 (PDT) Date: Thu, 20 May 2021 14:13:56 -0300 From: Marcelo Schmitt To: Wang Qing Cc: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Greg Kroah-Hartman , linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: iio: fix some formatting issues Message-ID: References: <1621389170-5850-1-git-send-email-wangqing@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1621389170-5850-1-git-send-email-wangqing@vivo.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wang, Nice patch for a start. Yet, I think there is room for some improvement. On 05/19, Wang Qing wrote: > fixing: If you wish, you may add here that this style check is reported by checkpatch. > CHECK: Alignment should match open parenthesis > #1351: FILE: drivers/staging/iio/addac/adt7316.c:1351: Checkpatch warns that commit log lines starting with '#' are dropped by git as comments. Is this intentional? > > CHECK: Alignment should match open parenthesis > #1378: FILE: drivers/staging/iio/addac/adt7316.c:1378: Same warning here. Its probably not a requirement, but the subject line could be more specific about where the changes are for. Maybe start with staging: iio: addac: or even staging: iio: addac: adt7316: Regards, Marcelo > > Signed-off-by: Wang Qing > --- > drivers/staging/iio/addac/adt7316.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c > index ccbafca..79467f0 100644 > --- a/drivers/staging/iio/addac/adt7316.c > +++ b/drivers/staging/iio/addac/adt7316.c > @@ -1348,9 +1348,9 @@ static ssize_t adt7316_show_in_analog_temp_offset(struct device *dev, > } > > static ssize_t adt7316_store_in_analog_temp_offset(struct device *dev, > - struct device_attribute *attr, > - const char *buf, > - size_t len) > + struct device_attribute *attr, > + const char *buf, > + size_t len) > { > struct iio_dev *dev_info = dev_to_iio_dev(dev); > struct adt7316_chip_info *chip = iio_priv(dev_info); > @@ -1375,9 +1375,9 @@ static ssize_t adt7316_show_ex_analog_temp_offset(struct device *dev, > } > > static ssize_t adt7316_store_ex_analog_temp_offset(struct device *dev, > - struct device_attribute *attr, > - const char *buf, > - size_t len) > + struct device_attribute *attr, > + const char *buf, > + size_t len) > { > struct iio_dev *dev_info = dev_to_iio_dev(dev); > struct adt7316_chip_info *chip = iio_priv(dev_info); > -- > 2.7.4 >