From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9059BC4707D for ; Fri, 21 May 2021 18:44:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B00861176 for ; Fri, 21 May 2021 18:44:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239045AbhEUSqK (ORCPT ); Fri, 21 May 2021 14:46:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:47762 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239031AbhEUSqI (ORCPT ); Fri, 21 May 2021 14:46:08 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1A72061163; Fri, 21 May 2021 18:44:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621622685; bh=eBKsVhFM7t+531GuI2ga4K2E8LIKpSSLx53E4bHMCtM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BbzUvGr25eQyJgqb7NjzhDZv0Uy8E9XNaa5fXPzFgxYwWTvKd1DwUKy61oNn+N4dI gtiId7QMFpC3pDGfMv4AHNf7rf2iyHkzu+ndN3Pll6UwE3KOzE1QUaCO3+hiva2jR+ sB7wq3/+eJPqhTByc+VjYlJXaRRsdQtFR3W806cM= Date: Fri, 21 May 2021 20:44:43 +0200 From: Greg Kroah-Hartman To: Kalle Valo Cc: linux-wireless@vger.kernel.org, "David S. Miller" , Jakub Kicinski , Kees Cook , Jason Gunthorpe , Chao Yu , Leon Romanovsky , b43-dev@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] b43: don't save dentries for debugfs Message-ID: References: <20210518163304.3702015-1-gregkh@linuxfoundation.org> <874kf0hr1t.fsf@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <874kf0hr1t.fsf@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 18, 2021 at 08:47:58PM +0300, Kalle Valo wrote: > Greg Kroah-Hartman writes: > > > There is no need to keep around the dentry pointers for the debugfs > > files as they will all be automatically removed when the subdir is > > removed. So save the space and logic involved in keeping them around by > > just getting rid of them entirely. > > > > By doing this change, we remove one of the last in-kernel user that was > > storing the result of debugfs_create_bool(), so that api can be cleaned > > up. > > > > Cc: Kalle Valo > > Cc: "David S. Miller" > > Cc: Jakub Kicinski > > Cc: Kees Cook > > Cc: Greg Kroah-Hartman > > Cc: Jason Gunthorpe > > Cc: Chao Yu > > Cc: Leon Romanovsky > > Cc: linux-wireless@vger.kernel.org > > Cc: b43-dev@lists.infradead.org > > Cc: netdev@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > Signed-off-by: Greg Kroah-Hartman > > --- > > drivers/net/wireless/broadcom/b43/debugfs.c | 34 +++------------------ > > drivers/net/wireless/broadcom/b43/debugfs.h | 3 -- > > 2 files changed, 5 insertions(+), 32 deletions(-) > > > > Note, I can take this through my debugfs tree if wanted, that way I can > > clean up the debugfs_create_bool() api at the same time. Otherwise it's > > fine, I can wait until next -rc1 for that to happen. > > Yeah, it's best that you take this via your tree. > > Acked-by: Kalle Valo Thanks, will do! greg k-h