From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Francois Gervais <fgervais@distech-controls.com>,
linux-rtc@vger.kernel.org,
Michael McCormick <michael.mccormick@enatel.net>,
Alessandro Zummo <a.zummo@towertech.it>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/1] rtc: pcf85063: fallback to parent of_node
Date: Sun, 23 May 2021 10:21:10 +0200 [thread overview]
Message-ID: <YKoQds5N0dP2Gjg5@kroah.com> (raw)
In-Reply-To: <20210522153636.ymyyq4vtzz2dq5k2@pengutronix.de>
On Sat, May 22, 2021 at 05:36:36PM +0200, Marc Kleine-Budde wrote:
> Hello Greg,
>
> On 17.04.2021 00:16:40, Alexandre Belloni wrote:
> > On Wed, 10 Mar 2021 16:10:26 -0500, Francois Gervais wrote:
> > > The rtc device node is always or at the very least can possibly be NULL.
> > >
> > > Since v5.12-rc1-dontuse/3c9ea42802a1fbf7ef29660ff8c6e526c58114f6 this
> > > will lead to a NULL pointer dereference.
> > >
> > > To fix this we fallback to using the parent node which is the i2c client
> > > node as set by devm_rtc_allocate_device().
> > >
> > > [...]
> >
> > Applied, thanks!
> >
> > [1/1] rtc: pcf85063: fallback to parent of_node
> > commit: 03531606ef4cda25b629f500d1ffb6173b805c05
> >
> > I made the fallback unconditionnal because this should have been that way from
> > the beginning as you point out.
>
> can you queue this for stable, as it causes a NULL Pointer deref with
> (at least) v5.12.
After it hits Linus's tree, let stable@vger.kernel.org know the id and
we will glad to add it to the stable trees.
thanks,
greg k-h
next prev parent reply other threads:[~2021-05-23 8:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 21:10 [PATCH 1/1] rtc: pcf85063: fallback to parent of_node Francois Gervais
2021-04-16 22:16 ` Alexandre Belloni
2021-05-22 15:36 ` Marc Kleine-Budde
2021-05-23 8:21 ` Greg Kroah-Hartman [this message]
2021-05-23 18:24 ` Marc Kleine-Budde
2021-05-24 12:45 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKoQds5N0dP2Gjg5@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=fgervais@distech-controls.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=michael.mccormick@enatel.net \
--cc=mkl@pengutronix.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).