From: Stefan Hajnoczi <stefanha@redhat.com>
To: Hannes Reinecke <hare@suse.de>
Cc: Dongli Zhang <dongli.zhang@oracle.com>,
virtualization@lists.linux-foundation.org,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-block@vger.kernel.org, mst@redhat.com, jasowang@redhat.com,
pbonzini@redhat.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, joe.jin@oracle.com,
junxiao.bi@oracle.com, srinivas.eeda@oracle.com
Subject: Re: [RFC] virtio_scsi: to poll and kick the virtqueue in timeout handler
Date: Mon, 24 May 2021 14:24:37 +0100 [thread overview]
Message-ID: <YKupFeOtc6Pr5KS2@stefanha-x1.localdomain> (raw)
In-Reply-To: <ac161748-15d2-2962-402e-23abca469623@suse.de>
[-- Attachment #1: Type: text/plain, Size: 1133 bytes --]
On Sun, May 23, 2021 at 09:39:51AM +0200, Hannes Reinecke wrote:
> On 5/23/21 8:38 AM, Dongli Zhang wrote:
> > This RFC is to trigger the discussion about to poll and kick the
> > virtqueue on purpose in virtio-scsi timeout handler.
> >
> > The virtio-scsi relies on the virtio vring shared between VM and host.
> > The VM side produces requests to vring and kicks the virtqueue, while the
> > host side produces responses to vring and interrupts the VM side.
> >
> > By default the virtio-scsi handler depends on the host timeout handler
> > by BLK_EH_RESET_TIMER to give host a chance to perform EH.
> >
> > However, this is not helpful for the case that the responses are available
> > on vring but the notification from host to VM is lost.
> >
> How can this happen?
> If responses are lost the communication between VM and host is broken, and
> we should rather reset the virtio rings themselves.
I agree. In principle it's fine to poll the virtqueue at any time, but I
don't understand the failure scenario here. It's not clear to me why the
device-to-driver vq notification could be lost.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-05-24 13:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-23 6:38 [RFC] virtio_scsi: to poll and kick the virtqueue in timeout handler Dongli Zhang
2021-05-23 7:39 ` Hannes Reinecke
2021-05-24 13:24 ` Stefan Hajnoczi [this message]
2021-05-25 6:33 ` Dongli Zhang
2021-05-25 16:47 ` Stefan Hajnoczi
2021-05-25 17:24 ` Hannes Reinecke
2021-05-25 17:34 ` Dongli Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKupFeOtc6Pr5KS2@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=dongli.zhang@oracle.com \
--cc=hare@suse.de \
--cc=jasowang@redhat.com \
--cc=jejb@linux.ibm.com \
--cc=joe.jin@oracle.com \
--cc=junxiao.bi@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=srinivas.eeda@oracle.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).