* [PATCH] mm: memcontrol: fix kernel-doc
@ 2021-05-24 10:24 Yang Li
2021-05-25 8:34 ` Michal Hocko
0 siblings, 1 reply; 3+ messages in thread
From: Yang Li @ 2021-05-24 10:24 UTC (permalink / raw)
To: hannes
Cc: mhocko, vdavydov.dev, akpm, cgroups, linux-mm, linux-kernel, Yang Li
Fix function name in mm/memcontrol.c kernel-doc comment
to remove a warning.
mm/memcontrol.c:6546: warning: expecting prototype for
mem_cgroup_protected(). Prototype was for
mem_cgroup_calculate_protection() instead.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
mm/memcontrol.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 64ada9e..030c1dc 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -6456,7 +6456,7 @@ static unsigned long effective_protection(unsigned long usage,
}
/**
- * mem_cgroup_protected - check if memory consumption is in the normal range
+ * mem_cgroup_calculate_protection - check if memory consumption is in the normal range
* @root: the top ancestor of the sub-tree being checked
* @memcg: the memory cgroup to check
*
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mm: memcontrol: fix kernel-doc
2021-05-24 10:24 [PATCH] mm: memcontrol: fix kernel-doc Yang Li
@ 2021-05-25 8:34 ` Michal Hocko
2021-05-25 16:09 ` Yang Shi
0 siblings, 1 reply; 3+ messages in thread
From: Michal Hocko @ 2021-05-25 8:34 UTC (permalink / raw)
To: Yang Li; +Cc: hannes, vdavydov.dev, akpm, cgroups, linux-mm, linux-kernel
On Mon 24-05-21 18:24:22, Yang Li wrote:
> Fix function name in mm/memcontrol.c kernel-doc comment
> to remove a warning.
>
> mm/memcontrol.c:6546: warning: expecting prototype for
> mem_cgroup_protected(). Prototype was for
> mem_cgroup_calculate_protection() instead.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Thanks!
> ---
> mm/memcontrol.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 64ada9e..030c1dc 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -6456,7 +6456,7 @@ static unsigned long effective_protection(unsigned long usage,
> }
>
> /**
> - * mem_cgroup_protected - check if memory consumption is in the normal range
> + * mem_cgroup_calculate_protection - check if memory consumption is in the normal range
> * @root: the top ancestor of the sub-tree being checked
> * @memcg: the memory cgroup to check
> *
> --
> 1.8.3.1
--
Michal Hocko
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm: memcontrol: fix kernel-doc
2021-05-25 8:34 ` Michal Hocko
@ 2021-05-25 16:09 ` Yang Shi
0 siblings, 0 replies; 3+ messages in thread
From: Yang Shi @ 2021-05-25 16:09 UTC (permalink / raw)
To: Michal Hocko
Cc: Yang Li, Johannes Weiner, Vladimir Davydov, Andrew Morton,
Cgroups, Linux MM, Linux Kernel Mailing List
On Tue, May 25, 2021 at 1:34 AM Michal Hocko <mhocko@suse.com> wrote:
>
> On Mon 24-05-21 18:24:22, Yang Li wrote:
> > Fix function name in mm/memcontrol.c kernel-doc comment
> > to remove a warning.
> >
> > mm/memcontrol.c:6546: warning: expecting prototype for
> > mem_cgroup_protected(). Prototype was for
> > mem_cgroup_calculate_protection() instead.
> >
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
>
> Acked-by: Michal Hocko <mhocko@suse.com>
It seems this has been covered by Mel's W=1 warning cleanup series,
see https://lore.kernel.org/linux-mm/20210520084809.8576-7-mgorman@techsingularity.net/.
>
> Thanks!
>
> > ---
> > mm/memcontrol.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> > index 64ada9e..030c1dc 100644
> > --- a/mm/memcontrol.c
> > +++ b/mm/memcontrol.c
> > @@ -6456,7 +6456,7 @@ static unsigned long effective_protection(unsigned long usage,
> > }
> >
> > /**
> > - * mem_cgroup_protected - check if memory consumption is in the normal range
> > + * mem_cgroup_calculate_protection - check if memory consumption is in the normal range
> > * @root: the top ancestor of the sub-tree being checked
> > * @memcg: the memory cgroup to check
> > *
> > --
> > 1.8.3.1
>
> --
> Michal Hocko
> SUSE Labs
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-25 16:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-24 10:24 [PATCH] mm: memcontrol: fix kernel-doc Yang Li
2021-05-25 8:34 ` Michal Hocko
2021-05-25 16:09 ` Yang Shi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).