From: Andrew Lunn <andrew@lunn.ch>
To: Peter Geis <pgwipeout@gmail.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
clang-built-linux@googlegroups.com,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH 2/2] net: phy: abort loading yt8511 driver in unsupported modes
Date: Tue, 25 May 2021 15:03:49 +0200 [thread overview]
Message-ID: <YKz1teE92Q3/+JMj@lunn.ch> (raw)
In-Reply-To: <20210525122615.3972574-3-pgwipeout@gmail.com>
On Tue, May 25, 2021 at 08:26:15AM -0400, Peter Geis wrote:
> While investigating the clang `ge` uninitialized variable report, it was
> discovered the default switch would have unintended consequences. Due to
> the switch to __phy_modify, the driver would modify the ID values in the
> default scenario.
>
> Fix this by promoting the interface mode switch and aborting when the
> mode is not a supported RGMII mode.
>
> This prevents the `ge` and `fe` variables from ever being used
> uninitialized.
>
> Fixes: b1b41c047f73 ("net: phy: add driver for Motorcomm yt8511 phy")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Peter Geis <pgwipeout@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
prev parent reply other threads:[~2021-05-25 13:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 12:26 [PATCH 0/2] fixes for yt8511 phy driver Peter Geis
2021-05-25 12:26 ` [PATCH 1/2] net: phy: fix yt8511 clang uninitialized variable warning Peter Geis
2021-05-25 13:01 ` Andrew Lunn
2021-05-25 13:11 ` Peter Geis
2021-05-25 13:59 ` Andrew Lunn
2021-05-25 12:26 ` [PATCH 2/2] net: phy: abort loading yt8511 driver in unsupported modes Peter Geis
2021-05-25 13:03 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKz1teE92Q3/+JMj@lunn.ch \
--to=andrew@lunn.ch \
--cc=clang-built-linux@googlegroups.com \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lkp@intel.com \
--cc=nathan@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pgwipeout@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).