From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD038C4743F for ; Tue, 8 Jun 2021 18:17:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C451E61376 for ; Tue, 8 Jun 2021 18:17:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233944AbhFHSTX (ORCPT ); Tue, 8 Jun 2021 14:19:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231652AbhFHSTV (ORCPT ); Tue, 8 Jun 2021 14:19:21 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1CBEC061574 for ; Tue, 8 Jun 2021 11:17:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Co//ogi0KDTBikV6nydb3Go2X95ksXSe8+9miI8T9iQ=; b=XqG0jOqyMCpsVnKu6OAOf7cesn E2JdDxB74rXo3x/fdJ0BvS0gKeX4k33xRx8wC9uGxxVTZVym9FQC5Y2MTpuJs70UmH2mLtDOrvx91 bKyb10iErePQdNSqez88N+ot10ovaWpWn9WhBjRo7GQBnjceqjtMwivxyVxr3Uagdff4QZ/QF9vgr d8jwpb9jiib0/c2daiqQNzBN9sGxLDfmXC6PnNiTjs5YsbhXOUTc797gqQ/RcL+bS/90l5JutDeqk u97O/WQvaOnEl3VYhGSaqiVr4f0SHJWNNjLZ/VK6d5IKL7HTX56PbO8F3k5lB7CYsF87cza87RzTr QghaaP/g==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqgHq-004pSJ-40; Tue, 08 Jun 2021 18:17:21 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 7418030018A; Tue, 8 Jun 2021 20:17:20 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 5FE37201D304F; Tue, 8 Jun 2021 20:17:20 +0200 (CEST) Date: Tue, 8 Jun 2021 20:17:20 +0200 From: Peter Zijlstra To: Nathan Chancellor Cc: Nick Desaulniers , =?utf-8?B?RsSBbmctcnXDrCBTw7JuZw==?= , Josh Poimboeuf , lma@semihalf.com, Guenter Roeck , Juergen Gross , lb@semihalf.com, LKML , mbenes@suse.com, =?utf-8?B?UmFkb3PFgmF3?= Biernacki , upstream@semihalf.com, "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , clang-built-linux , Sami Tolvanen Subject: Re: [PATCH v3 16/16] objtool,x86: Rewrite retpoline thunk calls Message-ID: References: <20210604235046.w3hazgcpsg4oefex@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 08, 2021 at 10:29:56AM -0700, Nathan Chancellor wrote: > On 6/8/2021 10:22 AM, Peter Zijlstra wrote: > > Since it's a VM, can you use the gdb-stub to ask it where it's stuck? > > > > Unfortunately, this is the VM provided by the Windows Subsystem for Linux so > examining it is nigh-impossible :/ I am considering bisecting the transforms > that objtool does to try and figure out the one that causes the machine to > fail to boot or try to reproduce in a different hypervisor, unless you have > any other ideas. Does breaking Windows earn points similar to breaking the binary drivers? :-) :-) The below should kill this latest transform and would quickly confirm if the that is causing your problem. If that's not it, what was your last known working version? diff --git a/tools/objtool/check.c b/tools/objtool/check.c index e5947fbb9e7a..d0f231b9c5a1 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -1857,10 +1857,10 @@ static int decode_sections(struct objtool_file *file) * Must be after add_special_section_alts(), since this will emit * alternatives. Must be after add_{jump,call}_destination(), since * those create the call insn lists. - */ ret = arch_rewrite_retpolines(file); if (ret) return ret; + */ return 0; }