linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Salvatore Bonaccorso <carnil@debian.org>
Cc: "Laurențiu Păncescu" <lpancescu@gmail.com>,
	stable@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Backporting fix for #199981 to 4.19.y?
Date: Tue, 8 Jun 2021 16:35:30 +0200	[thread overview]
Message-ID: <YL+AMiD7falsvZOf@kroah.com> (raw)
In-Reply-To: <YLzAw27CQpdEshBl@eldamar.lan>

On Sun, Jun 06, 2021 at 02:34:11PM +0200, Salvatore Bonaccorso wrote:
> Hi Laurențiu, Greg,
> 
> On Fri, Jun 04, 2021 at 05:42:02PM +0200, Greg KH wrote:
> > On Fri, Jun 04, 2021 at 04:50:19PM +0200, Laurențiu Păncescu wrote:
> > > Hi Greg,
> > > 
> > > On 6/3/21 11:19 AM, Greg KH wrote:
> > > > That commit does not apply cleanly and I need a backported version.  Can
> > > > you do that and test it to verify it works and then send it to us to be
> > > > applied?
> > > 
> > > I now have a patch against linux-4.19.y, tested on my EeePC just now: the
> > > battery status and discharge rate are shown correctly.
> > > 
> > > I've never submitted a patch before, should I put "commit <short-hash>
> > > upstream." as the first line of my commit message, followed by another line
> > > stating which branch I would like this to be merged to? Should I also
> > > include the original commit message of the backported commit? And then use
> > > git format-patch? I just read through [1] and [2], but they don't say
> > > anything specific about commit messages for backported patches.
> > 
> > Yes, what you describe here should be great.  Look at the stable mailing
> > list archives on lore.kernel.org for other examples of this happening,
> > https://lore.kernel.org/r/20210603162852.1814513-1-zsm@chromium.org is
> > one example.
> 
> Instead of doing a specific backport, maybe it is enough to pick
> a46393c02c76 ("ACPI: probe ECDT before loading AML tables regardless
> of module-level code flag") frst on 4.19.y and then the mentioned fix
> b1c0330823fe ("ACPI: EC: Look for ECDT EC after calling
> acpi_load_tables()").

I do not see a commit a46393c02c76 in Linus's tree :(

Are you sure these ids are correct?

thanks,

greg k-h

  parent reply	other threads:[~2021-06-08 14:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-03  7:53 Backporting fix for #199981 to 4.19.y? Laurențiu Păncescu
2021-06-03  8:07 ` Greg KH
2021-06-03  8:24   ` Laurențiu Păncescu
2021-06-03  9:19     ` Greg KH
2021-06-04 14:50       ` Laurențiu Păncescu
2021-06-04 15:42         ` Greg KH
2021-06-06 12:34           ` Salvatore Bonaccorso
2021-06-06 16:04             ` Laurențiu Păncescu
2021-06-08 14:35             ` Greg KH [this message]
2021-06-08 15:45               ` Laurențiu Păncescu
2021-06-08 16:57                 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YL+AMiD7falsvZOf@kroah.com \
    --to=greg@kroah.com \
    --cc=carnil@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lpancescu@gmail.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).