From: Thierry Reding <thierry.reding@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: "Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"Nikola Milosavljević" <mnidza@outlook.com>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Peter Geis" <pgwipeout@gmail.com>,
"Nicolas Chauvet" <kwizart@gmail.com>,
"Viresh Kumar" <vireshk@kernel.org>,
"Stephen Boyd" <sboyd@kernel.org>,
"Matt Merhar" <mattmerhar@protonmail.com>,
"Paul Fertser" <fercerpav@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mikko Perttunen" <mperttunen@nvidia.com>,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
"Nathan Chancellor" <nathan@kernel.org>,
linux-clk@vger.kernel.org
Subject: Re: [PATCH v6 08/14] memory: tegra: Enable compile testing for all drivers
Date: Mon, 7 Jun 2021 16:19:49 +0200 [thread overview]
Message-ID: <YL4rBYkWHpeit66m@orome.fritz.box> (raw)
In-Reply-To: <a1f20257-f041-966e-c37e-5c81c4cf94d9@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2028 bytes --]
On Mon, Jun 07, 2021 at 05:01:02PM +0300, Dmitry Osipenko wrote:
> 07.06.2021 16:36, Thierry Reding пишет:
> >> /bin/ld: warning: orphan section `__reservedmem_of_table' from `drivers/memory/tegra/tegra210-emc-table.o' being placed in section `__reservedmem_of_table'
> >> /bin/ld: drivers/memory/tegra/mc.o: in function `tegra_mc_probe':
> >> mc.c:(.text+0x87a): undefined reference to `reset_controller_register'
> >> make[1]: *** [/home/buildbot/worker/builddir/build/Makefile:1191: vmlinux] Error 1
> ...
>
> > Not sure what to do about that orphaned __reservedmem_of_table section.
> > Maybe all we need to do is to select OF_RESERVED_MEM from
> > TEGRA210_EMC_TABLE?
>
> Select won't work easily, but the dependency for TEGRA210_EMC should.
Select works if I also select OF_EARLY_FLATTREE. That's slightly odd
because typically that's something that the platform would select, but
there's precedent for doing this in drivers/clk/x86/Kconfig, so I think
it'd be fine.
The attached patch resolves both of the above issues for me.
Krzysztof: do you want to squash that into the problematic patch or do
you want me to send this as a follow-up patch for you to apply? I guess
the latter since you've already sent out the PR for Will and ARM SoC?
Thierry
--- >8 ---
diff --git a/drivers/memory/tegra/Kconfig b/drivers/memory/tegra/Kconfig
index f9bae36c03a3..ae8c57b921e6 100644
--- a/drivers/memory/tegra/Kconfig
+++ b/drivers/memory/tegra/Kconfig
@@ -4,6 +4,7 @@ config TEGRA_MC
default y
depends on ARCH_TEGRA || (COMPILE_TEST && COMMON_CLK)
select INTERCONNECT
+ select RESET_CONTROLLER
help
This driver supports the Memory Controller (MC) hardware found on
NVIDIA Tegra SoCs.
@@ -48,6 +49,8 @@ config TEGRA124_EMC
config TEGRA210_EMC_TABLE
bool
depends on ARCH_TEGRA_210_SOC || COMPILE_TEST
+ select OF_EARLY_FLATTREE
+ select OF_RESERVED_MEM
config TEGRA210_EMC
tristate "NVIDIA Tegra210 External Memory Controller driver"
--- >8 ---
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-06-07 14:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 2:31 [PATCH v6 00/14] NVIDIA Tegra memory and power management changes for 5.14 Dmitry Osipenko
2021-06-01 2:31 ` [PATCH v6 01/14] regulator: core: Add regulator_sync_voltage_rdev() Dmitry Osipenko
2021-06-01 2:31 ` [PATCH v6 02/14] soc/tegra: regulators: Bump voltages on system reboot Dmitry Osipenko
2021-06-01 2:31 ` [PATCH v6 03/14] soc/tegra: Add stub for soc_is_tegra() Dmitry Osipenko
2021-06-01 2:31 ` [PATCH v6 04/14] soc/tegra: Add devm_tegra_core_dev_init_opp_table() Dmitry Osipenko
2021-06-01 2:31 ` [PATCH v6 05/14] soc/tegra: fuse: Add stubs needed for compile-testing Dmitry Osipenko
2021-06-01 2:31 ` [PATCH v6 06/14] clk: tegra: " Dmitry Osipenko
2021-06-01 2:31 ` [PATCH v6 07/14] memory: tegra: Fix compilation warnings on 64bit platforms Dmitry Osipenko
2021-06-01 2:31 ` [PATCH v6 08/14] memory: tegra: Enable compile testing for all drivers Dmitry Osipenko
2021-06-07 6:01 ` Krzysztof Kozlowski
2021-06-07 13:36 ` Thierry Reding
2021-06-07 13:37 ` Dmitry Osipenko
2021-06-07 14:01 ` Dmitry Osipenko
2021-06-07 14:19 ` Thierry Reding [this message]
2021-06-07 14:42 ` Krzysztof Kozlowski
2021-06-08 15:18 ` Dmitry Osipenko
2021-06-01 2:31 ` [PATCH v6 09/14] memory: tegra20-emc: Use devm_tegra_core_dev_init_opp_table() Dmitry Osipenko
2021-06-01 2:31 ` [PATCH v6 10/14] memory: tegra30-emc: " Dmitry Osipenko
2021-06-01 2:31 ` [PATCH v6 11/14] dt-bindings: soc: tegra-pmc: Document core power domain Dmitry Osipenko
2021-06-01 2:31 ` [PATCH v6 12/14] soc/tegra: pmc: Add " Dmitry Osipenko
2021-06-01 2:31 ` [PATCH v6 13/14] soc/tegra: pmc: Add driver state syncing Dmitry Osipenko
2021-06-01 2:31 ` [PATCH v6 14/14] soc/tegra: regulators: Support core domain " Dmitry Osipenko
2021-06-01 11:27 ` [PATCH v6 00/14] NVIDIA Tegra memory and power management changes for 5.14 Thierry Reding
2021-06-01 15:51 ` Dmitry Osipenko
2021-06-01 17:10 ` Thierry Reding
2021-06-01 18:00 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YL4rBYkWHpeit66m@orome.fritz.box \
--to=thierry.reding@gmail.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=fercerpav@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=kwizart@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mattmerhar@protonmail.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=mnidza@outlook.com \
--cc=mperttunen@nvidia.com \
--cc=nathan@kernel.org \
--cc=pgwipeout@gmail.com \
--cc=sboyd@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).