From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <chao@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 3/3 v2] f2fs: clean up /sys/fs/f2fs/<disk>/features
Date: Mon, 7 Jun 2021 09:58:20 -0700 [thread overview]
Message-ID: <YL5QLFl4RKpL/vAR@google.com> (raw)
In-Reply-To: <f8edad10-dfad-d12e-9c60-e007d132fbda@kernel.org>
On 06/07, Chao Yu wrote:
> On 2021/6/6 13:36, Jaegeuk Kim wrote:
> > Let's create /sys/fs/f2fs/<disk>/feature_list/ to meet sysfs rule.
> >
> > Note that there are three feature list entries:
> > 1) /sys/fs/f2fs/features
> > : shows runtime features supported by in-kernel f2fs along with Kconfig.
> > - ref. F2FS_FEATURE_RO_ATTR()
> >
> > 2) /sys/fs/f2fs/$s_id/features <deprecated>
> > : shows on-disk features enabled by mkfs.f2fs, used for old kernels. This
> > won't add new feature anymore, and thus, users should check entries in 3)
> > instead of this 2).
> >
> > 3) /sys/fs/f2fs/$s_id/feature_list
> > : shows on-disk features enabled by mkfs.f2fs per instance, which follows
> > sysfs entry rule where each entry should expose single value.
> > This list covers old feature list provided by 2) and beyond. Therefore,
> > please add new on-disk feature in this list only.
> > - ref. F2FS_SB_FEATURE_RO_ATTR()
> >
> > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
>
> Reviewed-by: Chao Yu <yuchao0@huawei.com>
>
> > +static struct kobj_type f2fs_feature_list_ktype = {
> > + .default_groups = f2fs_sb_feat_groups,
> > + .sysfs_ops = &f2fs_feature_list_attr_ops,
> > + .release = f2fs_feature_list_kobj_release,
> > +};
> > +
> > +
>
> Nitpick, one redundant blank line.
Done.
>
> Thanks,
next prev parent reply other threads:[~2021-06-07 16:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-05 0:32 [PATCH 1/3] f2fs: Advertise encrypted casefolding in sysfs Jaegeuk Kim
2021-06-05 0:32 ` [PATCH 2/3] f2fs: add pin_file in feature list Jaegeuk Kim
2021-06-07 13:57 ` [f2fs-dev] " Chao Yu
2021-06-05 0:32 ` [PATCH 3/3] f2fs: clean up /sys/fs/f2fs/<disk>/features Jaegeuk Kim
2021-06-05 2:02 ` [f2fs-dev] " Eric Biggers
2021-06-06 5:36 ` [PATCH 3/3 v2] " Jaegeuk Kim
2021-06-07 14:00 ` [f2fs-dev] " Chao Yu
2021-06-07 16:58 ` Jaegeuk Kim [this message]
2021-06-10 23:09 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YL5QLFl4RKpL/vAR@google.com \
--to=jaegeuk@kernel.org \
--cc=chao@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).