From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99DFFC47095 for ; Mon, 7 Jun 2021 17:19:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8571461029 for ; Mon, 7 Jun 2021 17:19:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231282AbhFGRUz (ORCPT ); Mon, 7 Jun 2021 13:20:55 -0400 Received: from mga17.intel.com ([192.55.52.151]:34805 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231160AbhFGRUx (ORCPT ); Mon, 7 Jun 2021 13:20:53 -0400 IronPort-SDR: TjhP5k31K/DBx9zZNm8JoYZ14pE/rkt8X5a2AyiZmFVMAmMuZlJm1thlqA6CvkIY1ARuMQJXqC dPaBkPXdKNVw== X-IronPort-AV: E=McAfee;i="6200,9189,10008"; a="185037699" X-IronPort-AV: E=Sophos;i="5.83,255,1616482800"; d="scan'208";a="185037699" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2021 10:19:01 -0700 IronPort-SDR: drV02vyY3tgxZUv0Dq4ebXPjQD86j7NYMJ1kDy7Hi1YNQnPjgNlHQGionhAOhBJ6FNMfxo/j8h 2c8ZcPxYqFVw== X-IronPort-AV: E=Sophos;i="5.83,255,1616482800"; d="scan'208";a="418594405" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2021 10:18:58 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lqItr-000JUQ-HH; Mon, 07 Jun 2021 20:18:55 +0300 Date: Mon, 7 Jun 2021 20:18:55 +0300 From: Andy Shevchenko To: Dave Young Cc: Jean Delvare , linux-kernel@vger.kernel.org, Mika Westerberg , Javier =?iso-8859-1?B?VGnh?= , kexec@lists.infradead.org, Eric Biederman , linux-efi , Matt Fleming , Ard Biesheuvel Subject: Re: [PATCH v1 0/2] firmware: dmi_scan: Make it work in kexec'ed kernel Message-ID: References: <20161202195416.58953-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 07, 2021 at 07:22:21PM +0300, Andy Shevchenko wrote: > On Sat, Jun 05, 2021 at 03:51:05PM +0800, Dave Young wrote: > > On 06/02/21 at 11:53am, Andy Shevchenko wrote: > > > On Wed, Jun 02, 2021 at 11:42:14AM +0300, Andy Shevchenko wrote: > > > > On Fri, Dec 02, 2016 at 09:54:14PM +0200, Andy Shevchenko wrote: > > > > > Until now DMI information is lost when kexec'ing. Fix this in the same way as > > > > > it has been done for ACPI RSDP. > > > > > > > > > > Series has been tested on Galileo Gen2 where DMI is used by drivers, in > > > > > particular the default I2C host speed is choosen based on DMI system > > > > > information and now gets it correct. > > > > > > > > Still nothing happens for a while and problem still exists. > > > > Can we do something about it, please? > > > > Seems I totally missed this thread. Old emails lost. > > You can always access to it via lore :-) > https://lore.kernel.org/linux-efi/20161217105721.GB6922@dhcp-128-65.nay.redhat.com/T/#u > > (Okay, it's not full, but contains main parts anyway) > > > > The question Ard asked is to confirm if the firmware converted the > > SMBIOS3 addr to a virtual address after exit boot service. I do not > > remember some easy way to check it due to lost the context of the code. > > But you can try to check it via dmesg|grep SMBIOS both in normal boot > > and kexeced boot log. And then compare if those addresses are > > identical. > > > > If the SMBIOS3 addr in kexec kernel is different then it should have > > been modified by firmware. Then we need patch kernel and kexec-tools to > > support it. > > > > You can try below patch to see if it works: > > So, AFAIU I have to apply patch to kexec tools for the fist kernel + userspace > and apply kernel patch for the second kernel? Or it's all for the first one? > > > apply a kexec-tools patch to kexec-tools if you do not use kexec -s > > (kexec_file_load): > > Here is how we are using it: > https://github.com/andy-shev/buildroot/blob/intel/board/intel/common/netboot/udhcpc-script.sh#L54 Okay, thanks for the patches. I have applied them to both kernels, so the first one and second one are the same and kexec tools have a patch provided in the user space of the both kernels (only first one in use though). Before applying your patch, I have reverted my hacks (as per this series). Result is: # uname -a Linux buildroot 5.13.0-rc5+ #1 SMP Mon Jun 7 19:49:40 EEST 2021 i586 GNU/Linux # dmidecode # dmidecode 3.3 Scanning /dev/mem for entry point. # No SMBIOS nor DMI entry point found, sorry. I.o.w. it does NOT fix the issue. My patches do (with a hint from user space). -- With Best Regards, Andy Shevchenko