linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Jiří Prchal" <jiri.prchal@aksignal.cz>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>,
	Christian Eggers <ceggers@arri.de>, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v7 4/5] nvmem: eeprom: at25: export FRAM serial num
Date: Tue, 8 Jun 2021 11:03:42 +0200	[thread overview]
Message-ID: <YL8ybqOfgOqjlpoX@kroah.com> (raw)
In-Reply-To: <56f088fe-8db2-54d4-bef3-72e5f893a414@aksignal.cz>

On Mon, Jun 07, 2021 at 04:47:44PM +0200, Jiří Prchal wrote:
> 
> 
> On 07. 06. 21 14:36, Greg Kroah-Hartman wrote:
> > On Mon, Jun 07, 2021 at 02:26:39PM +0200, Jiri Prchal wrote:
> > > +	return sysfs_emit(buf, "%016llx\n", *(unsigned long long *)at25->sernum);
> > 
> > That's a horrid hack, why not use the %*phN modifier?
> 
> Prints as little endian, is that OK?

You tell me!  What tool is going to be reading this?  What do they
expect it to look like?

And it's a byte array, why would there be endian issues?

thanks,

greg k-h

  reply	other threads:[~2021-06-08  9:03 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-07 12:26 [PATCH v7 0/5] add support for FRAM Jiri Prchal
2021-06-07 12:26 ` [PATCH v7 1/5] nvmem: eeprom: at25: prepare basics for FRAM support Jiri Prchal
2021-06-07 12:35   ` Greg Kroah-Hartman
2021-06-07 12:26 ` [PATCH v7 2/5] nvmem: eeprom: at25: add support for FRAM Jiri Prchal
2021-06-07 12:26 ` [PATCH v7 3/5] nvmem: eeprom: add documentation " Jiri Prchal
2021-06-07 13:09   ` Enrico Weigelt, metux IT consult
2021-06-07 12:26 ` [PATCH v7 4/5] nvmem: eeprom: at25: export FRAM serial num Jiri Prchal
2021-06-07 12:36   ` Greg Kroah-Hartman
2021-06-07 14:47     ` Jiří Prchal
2021-06-08  9:03       ` Greg Kroah-Hartman [this message]
2021-06-08  9:45         ` Jiří Prchal
2021-06-08  9:53           ` Greg Kroah-Hartman
2021-06-08 10:07             ` Jiří Prchal
2021-06-10  7:51               ` Jiří Prchal
2021-06-07 12:26 ` [PATCH v7 5/5] nvmem: eeprom: add documentation of sysfs sernum file Jiri Prchal
2021-06-07 12:37   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YL8ybqOfgOqjlpoX@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=ceggers@arri.de \
    --cc=devicetree@vger.kernel.org \
    --cc=jiri.prchal@aksignal.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).