From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C23AEC4708E for ; Fri, 28 May 2021 10:10:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A92976135F for ; Fri, 28 May 2021 10:10:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236396AbhE1KMX (ORCPT ); Fri, 28 May 2021 06:12:23 -0400 Received: from mail.thorsis.com ([92.198.35.195]:49155 "EHLO mail.thorsis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235672AbhE1KMV (ORCPT ); Fri, 28 May 2021 06:12:21 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.thorsis.com (Postfix) with ESMTP id 578CBF61; Fri, 28 May 2021 12:10:46 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail.thorsis.com Received: from mail.thorsis.com ([127.0.0.1]) by localhost (mail.thorsis.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4YyQp2lCo78k; Fri, 28 May 2021 12:10:46 +0200 (CEST) Received: by mail.thorsis.com (Postfix, from userid 109) id 2637FE5C; Fri, 28 May 2021 12:10:45 +0200 (CEST) Date: Fri, 28 May 2021 12:10:36 +0200 From: Alexander Dahl To: Lee Jones Cc: linux-kernel@vger.kernel.org, Pavel Machek , John Lenz , Richard Purdie , linux-leds@vger.kernel.org Subject: Re: [PATCH 03/15] leds: led-class: Fix incorrectly documented param 'dev' Message-ID: Mail-Followup-To: Lee Jones , linux-kernel@vger.kernel.org, Pavel Machek , John Lenz , Richard Purdie , linux-leds@vger.kernel.org References: <20210528090629.1800173-1-lee.jones@linaro.org> <20210528090629.1800173-4-lee.jones@linaro.org> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210528090629.1800173-4-lee.jones@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Am Fri, May 28, 2021 at 10:06:17AM +0100 schrieb Lee Jones: > Fixes the following W=1 kernel build warning(s): > > drivers/leds/led-class.c:521: warning: Function parameter or member 'dev' not described in 'devm_led_classdev_unregister' > drivers/leds/led-class.c:521: warning: Excess function parameter 'parent' description in 'devm_led_classdev_unregister' > > Cc: Pavel Machek > Cc: John Lenz > Cc: Richard Purdie > Cc: linux-leds@vger.kernel.org > Signed-off-by: Lee Jones > --- > drivers/leds/led-class.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c > index 2e495ff678562..16271a1de12a7 100644 > --- a/drivers/leds/led-class.c > +++ b/drivers/leds/led-class.c > @@ -513,7 +513,7 @@ static int devm_led_classdev_match(struct device *dev, void *res, void *data) > > /** > * devm_led_classdev_unregister() - resource managed led_classdev_unregister() > - * @parent: The device to unregister. > + * @dev: The device to unregister. > * @led_cdev: the led_classdev structure for this device. > */ > void devm_led_classdev_unregister(struct device *dev, Fixes: ca1bb4ee4c3a ("leds: Introduce devres helper for led_classdev_register") Reviewed-by: Alexander Dahl Greets Alex