linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>,
	Agneli <poczt@protonmail.ch>, Paul Fertser <fercerpav@gmail.com>,
	Svyatoslav Ryhel <clamor95@gmail.com>,
	linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 04/10] ARM: tegra: Add reg property to Tegra20 EMC table device-tree nodes
Date: Mon, 31 May 2021 11:14:49 +0200	[thread overview]
Message-ID: <YLSpCXNtut3z8U9a@orome.fritz.box> (raw)
In-Reply-To: <20210510202600.12156-5-digetx@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1079 bytes --]

On Mon, May 10, 2021 at 11:25:54PM +0300, Dmitry Osipenko wrote:
> The reg property is now specified for the emc-tables nodes in the Tegra20
> device-tree binding. Add reg property to the EMC table device-tree nodes
> of Tegra20 board device-trees in order to silence dt_binding_check warning
> about the missing property.
> 
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
>  arch/arm/boot/dts/tegra20-acer-a500-picasso.dts | 4 ++++
>  arch/arm/boot/dts/tegra20-paz00.dts             | 1 +
>  2 files changed, 5 insertions(+)

In retrospect we should've just used "reg" in the first place rather
than adding the custom "nvidia,ram-code". It's a bit redundant to have
both of them with the same value. I wonder if we should deprecate the
use of "nvidia,ram-code" and at least make the code look at the "reg"
property first and only fall back to "nvidia,ram-code" if "reg" does
not exist. We probably won't ever be able to get rid of the fallback
for backwards-compatibility reasons, but at least that would make the
intent a bit clearer.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2021-05-31  9:13 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-10 20:25 [PATCH v1 00/10] NVIDIA Tegra ARM32 device-tree improvements for 5.14 Dmitry Osipenko
2021-05-10 20:25 ` [PATCH v1 01/10] ARM: tegra: acer-a500: Improve microphone detection Dmitry Osipenko
2021-05-10 20:25 ` [PATCH v1 02/10] ARM: tegra: acer-a500: Specify proper voltage for WiFi SDIO bus Dmitry Osipenko
2021-05-10 20:25 ` [PATCH v1 03/10] ARM: tegra: acer-a500: Bump thermal trips by 10C Dmitry Osipenko
2021-05-14 21:16   ` Michał Mirosław
2021-05-14 22:17     ` Dmitry Osipenko
2021-06-11  9:52     ` Daniel Lezcano
2021-06-12 10:40       ` Dmitry Osipenko
2021-06-12 14:24         ` Daniel Lezcano
2021-06-13  0:25           ` Dmitry Osipenko
2021-06-13 18:19             ` Daniel Lezcano
2021-06-15 12:53               ` Dmitry Osipenko
2021-06-15 13:05                 ` Daniel Lezcano
2021-06-15 13:26                   ` Dmitry Osipenko
2021-05-10 20:25 ` [PATCH v1 04/10] ARM: tegra: Add reg property to Tegra20 EMC table device-tree nodes Dmitry Osipenko
2021-05-31  9:14   ` Thierry Reding [this message]
2021-05-31 20:45     ` Dmitry Osipenko
2021-06-01 11:25       ` Thierry Reding
2021-06-01 17:44         ` Dmitry Osipenko
2021-06-01 17:54         ` Dmitry Osipenko
2021-05-10 20:25 ` [PATCH v1 05/10] ARM: tegra: wm8903: Fix polarity of headphones-detection GPIO in device-trees Dmitry Osipenko
2021-05-10 20:25 ` [PATCH v1 06/10] ARM: tegra: paz00: Add CPU thermal zone Dmitry Osipenko
2021-05-10 20:25 ` [PATCH v1 07/10] ARM: tegra: nexus7: Add i2c-thermtrip node Dmitry Osipenko
2021-05-10 20:25 ` [PATCH v1 08/10] ARM: tegra: nexus7: Improve thermal zones Dmitry Osipenko
2021-05-10 20:25 ` [PATCH v1 09/10] ARM: tegra: nexus7: Remove monitored-battery property Dmitry Osipenko
2021-05-10 20:26 ` [PATCH v1 10/10] ARM: tegra: nexus7: Correct 3v3 regulator GPIO of PM269 variant Dmitry Osipenko
2021-05-31  8:58 ` [PATCH v1 00/10] NVIDIA Tegra ARM32 device-tree improvements for 5.14 Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YLSpCXNtut3z8U9a@orome.fritz.box \
    --to=thierry.reding@gmail.com \
    --cc=clamor95@gmail.com \
    --cc=digetx@gmail.com \
    --cc=fercerpav@gmail.com \
    --cc=jonathanh@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=poczt@protonmail.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).