linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Hailong Liu <liuhailongg6@163.com>,
	Ingo Molnar <mingo@redhat.com>,
	Juri Lelli <juri.lelli@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
	Daniel Bristot de Oliveira <bristot@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Masahiro Yamada <masahiroy@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Vitor Massaru Iha <vitor@massaru.org>,
	Sedat Dilek <sedat.dilek@gmail.com>,
	Wei Yang <richard.weiyang@gmail.com>,
	linux-kernel@vger.kernel.org,
	Hailong Liu <liu.hailong6@zte.com.cn>
Subject: Re: [PATCH] sched/debug:fix stale comments of sched_debug
Date: Tue, 1 Jun 2021 09:56:51 +0200	[thread overview]
Message-ID: <YLXoQzcUwSO775Z6@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <YLUJQp4fdEAW4GzY@smile.fi.intel.com>

On Mon, May 31, 2021 at 07:05:22PM +0300, Andy Shevchenko wrote:
> > >> --- a/lib/Kconfig.debug
> > >> +++ b/lib/Kconfig.debug
> > >> @@ -1166,7 +1166,7 @@ config SCHED_DEBUG
> > >>  	depends on DEBUG_KERNEL && PROC_FS
> > > 
> > > Are the dependencies correct?
> > 
> > Based on your suggestion, I checked and it turned out that PROC_FS is not
> > the correct dependency, but DEBUG_FS. 
> 
> I guess you missed something.
> 
> > Shoud I change it to DEBUG_FS?
> 
> Please, double check.

Thing is that proc_sched_show_task() still wants PROC_FS, i've not yet
found a suitable debugfs based location for that.

And DEBUG_FS doesn't need a dependency; it has complete DEBUG_FS=n
wrappers and will build fine. Arguably selecting SCHED_DEBUG without
DEBUG_FS is daft, but it should work.

  reply	other threads:[~2021-06-01  7:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-30  2:51 [PATCH] sched/debug:fix stale comments of sched_debug Hailong Liu
2021-05-31  7:48 ` Andy Shevchenko
2021-05-31 14:09   ` Hailong Liu
2021-05-31 15:48     ` Peter Zijlstra
2021-05-31 16:05     ` Andy Shevchenko
2021-06-01  7:56       ` Peter Zijlstra [this message]
2021-06-01 12:58         ` Andy Shevchenko
2021-06-01 14:16           ` Hailong Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YLXoQzcUwSO775Z6@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bristot@redhat.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liu.hailong6@zte.com.cn \
    --cc=liuhailongg6@163.com \
    --cc=masahiroy@kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=ndesaulniers@google.com \
    --cc=richard.weiyang@gmail.com \
    --cc=rostedt@goodmis.org \
    --cc=sedat.dilek@gmail.com \
    --cc=vincent.guittot@linaro.org \
    --cc=vitor@massaru.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).