From: Matthew Wilcox <willy@infradead.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Justin He <Justin.He@arm.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Jonathan Corbet <corbet@lwn.net>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Luca Coelho <luciano.coelho@intel.com>,
Kalle Valo <kvalo@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Johannes Berg <johannes.berg@intel.com>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH RFCv2 2/3] lib/vsprintf.c: make %pD print full path for file
Date: Tue, 1 Jun 2021 16:44:00 +0100 [thread overview]
Message-ID: <YLZVwFh9MZJR3amM@casper.infradead.org> (raw)
In-Reply-To: <CAHp75VfYgEtJeiVp8b10Va54QShyg4DmWeufuB_WGC8C2SE2mQ@mail.gmail.com>
On Tue, Jun 01, 2021 at 06:36:41PM +0300, Andy Shevchenko wrote:
> On Tue, Jun 1, 2021 at 6:32 PM Matthew Wilcox <willy@infradead.org> wrote:
> > On Tue, Jun 01, 2021 at 02:42:15PM +0000, Justin He wrote:
>
> ...
>
> > Just don't put anything
> > in the buffer if the user didn't supply enough space. As long as you
> > get the return value right, they know the string is bad (or they don't
> > care if the string is bad)
>
> It might be that I'm out of context here, but printf() functionality
> in the kernel (vsprintf() if being precise) and its users consider
> that it should fill buffer up to the end of whatever space is
> available.
Do they though? What use is it to specify a small buffer, print a
large filename into it and then use that buffer, knowing that it wasn't
big enough? That would help decide whether we should print the
start or the end of the filename.
Remember, we're going for usefulness here, not abiding by the letter of
the standard under all circumstances, no matter the cost. At least
partially because we're far outside the standard here; POSIX does
not specify what %pD does.
"The argument shall be a pointer to void. The value of the
pointer is converted to a sequence of printable characters, in an
implementation-defined manner."
next prev parent reply other threads:[~2021-06-01 15:45 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 11:39 [PATCH RFCv2 0/3] make '%pD' print full path for file Jia He
2021-05-28 11:39 ` [PATCH RFCv2 1/3] fs: introduce helper d_path_fast() Jia He
2021-05-28 12:44 ` Al Viro
2021-05-28 12:51 ` Matthew Wilcox
2021-05-28 14:23 ` Justin He
2021-05-28 11:39 ` [PATCH RFCv2 2/3] lib/vsprintf.c: make %pD print full path for file Jia He
2021-05-28 12:59 ` Matthew Wilcox
2021-05-28 14:22 ` Justin He
2021-05-28 14:52 ` Matthew Wilcox
2021-05-28 15:09 ` Justin He
2021-05-28 15:22 ` Matthew Wilcox
2021-05-31 0:39 ` Justin He
2021-06-01 14:42 ` Justin He
2021-06-01 15:30 ` Matthew Wilcox
2021-06-01 15:36 ` Andy Shevchenko
2021-06-01 15:44 ` Matthew Wilcox [this message]
2021-06-01 15:53 ` Andy Shevchenko
2021-06-01 16:10 ` Andy Shevchenko
2021-06-01 17:05 ` Matthew Wilcox
2021-06-01 19:01 ` Rasmus Villemoes
2021-06-02 5:47 ` Justin He
2021-05-28 20:06 ` Rasmus Villemoes
2021-05-30 15:18 ` Matthew Wilcox
2021-05-31 9:40 ` Petr Mladek
2021-05-28 11:39 ` [PATCH RFCv2 3/3] s390/hmcdrv: remove the redundant directory path in debug message Jia He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLZVwFh9MZJR3amM@casper.infradead.org \
--to=willy@infradead.org \
--cc=Justin.He@arm.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=borntraeger@de.ibm.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=johannes.berg@intel.com \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=luciano.coelho@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).