From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB664C47083 for ; Wed, 2 Jun 2021 10:43:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B3A69613B4 for ; Wed, 2 Jun 2021 10:43:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229721AbhFBKpe (ORCPT ); Wed, 2 Jun 2021 06:45:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229603AbhFBKp1 (ORCPT ); Wed, 2 Jun 2021 06:45:27 -0400 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D319FC061574 for ; Wed, 2 Jun 2021 03:43:44 -0700 (PDT) Received: by mail-wm1-x330.google.com with SMTP id p13-20020a05600c358db029019f44afc845so1376190wmq.3 for ; Wed, 02 Jun 2021 03:43:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=uetljnpMVagZUL5muUxDZIQ/D9uiCnsyXeZAzCtugkc=; b=S5AMEA55e6WiHfILJvvLPJjjSa/Yq2hHfihL5FLlwc0nkqiEigDVv6zGaQ9Zqw30CZ ZcNArqEE1KLDPi62Lj3DON4XRA4lRQEPl3mkiGXqf1NuzcbVyz2xB5213Beslcbi0VY+ vsODVyRmobfR1fCmUKCnp2nQgPmer3uq6shiln93ca9H6FsgwmDg30qGDQ8d9/7e24Mp CSLPgs6X+XyQ7pC/c2x8ETo1zkBVPUtq9sPOkmehhhoJFv3lhBEv40tvpOSBlEY1/b8H QUE7F5ZbBoi4Gyi+g8C3tw7hkEOfNdrM3DT6aidkaFGmRGF0N81BVxOpbVVxuR5GQeKr JnRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=uetljnpMVagZUL5muUxDZIQ/D9uiCnsyXeZAzCtugkc=; b=hiki7Y41Zorr2eJdzzYbYVLan7wZd7rnSiNingIn+MCe8PFnjVXY29pZZJie+ErniR hQy2JHPd9J9v6RzFmzPIhr2cS5bMw3uPakeh0Uqb/GIKbgfbZKcjTNBdtC1YP8vd7hfY BzI9Gs837+X12PzvbdGpKP6BGEJRIHxbI3jXXtViqbhz4cXF30wr4N9wkP0TLnIFxcNB swfwvZZ+kNz0CYcoPFyCC5MHOtAoBj1ii/vAFUDtOAY9R0TMNt8RznRe5RKT9AH/xtu+ yM1743YiKSI7aYCd8DgZitxtTGAjj2slMAnJim1ixDAECfQFqguf9I7ty14OM2pPw9+P DLFw== X-Gm-Message-State: AOAM531mmBsbLCsHb3aVJMzLLnAiRd1bvTL1S3p5j1lSUv5E/G7hsMB6 7wPT9D4yvvy/9lw1oeyhJMMZHA== X-Google-Smtp-Source: ABdhPJwVt/mkHfPZsWQ7XeVPY+TVxGZoc9ruOznSEZgl2V+JcARglYdu24JT3h1Ue3fGnhgc5QDPqA== X-Received: by 2002:a7b:c042:: with SMTP id u2mr30819876wmc.127.1622630623364; Wed, 02 Jun 2021 03:43:43 -0700 (PDT) Received: from google.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id 31sm7003760wrc.96.2021.06.02.03.43.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 03:43:42 -0700 (PDT) Date: Wed, 2 Jun 2021 10:43:40 +0000 From: Quentin Perret To: Yanan Wang Cc: Marc Zyngier , Will Deacon , Alexandru Elisei , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Catalin Marinas , James Morse , Julien Thierry , Suzuki K Poulose , Gavin Shan , wanghaibin.wang@huawei.com, zhukeqian1@huawei.com, yuzenghui@huawei.com Subject: Re: [PATCH v5 1/6] KVM: arm64: Introduce KVM_PGTABLE_S2_GUEST stage-2 flag Message-ID: References: <20210415115032.35760-1-wangyanan55@huawei.com> <20210415115032.35760-2-wangyanan55@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210415115032.35760-2-wangyanan55@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Yanan, On Thursday 15 Apr 2021 at 19:50:27 (+0800), Yanan Wang wrote: > diff --git a/arch/arm64/include/asm/kvm_pgtable.h b/arch/arm64/include/asm/kvm_pgtable.h > index c3674c47d48c..a43cbe697b37 100644 > --- a/arch/arm64/include/asm/kvm_pgtable.h > +++ b/arch/arm64/include/asm/kvm_pgtable.h > @@ -61,10 +61,12 @@ struct kvm_pgtable_mm_ops { > * @KVM_PGTABLE_S2_NOFWB: Don't enforce Normal-WB even if the CPUs have > * ARM64_HAS_STAGE2_FWB. > * @KVM_PGTABLE_S2_IDMAP: Only use identity mappings. > + * @KVM_PGTABLE_S2_GUEST: Whether the page-tables are guest stage-2. > */ > enum kvm_pgtable_stage2_flags { > KVM_PGTABLE_S2_NOFWB = BIT(0), > KVM_PGTABLE_S2_IDMAP = BIT(1), > + KVM_PGTABLE_S2_GUEST = BIT(2), Assuming that we need this flag (maybe not given Marc's suggestion on another patch), I'd recommend re-naming it to explain _what_ it does, rather than _who_ is using it. That's the principle we followed for e.g. KVM_PGTABLE_S2_IDMAP, so we should be consistent here as well. Thanks, Quentin