From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16F65C47083 for ; Wed, 2 Jun 2021 14:37:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EB0A2610E5 for ; Wed, 2 Jun 2021 14:37:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232024AbhFBOjJ (ORCPT ); Wed, 2 Jun 2021 10:39:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:59676 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231245AbhFBOjH (ORCPT ); Wed, 2 Jun 2021 10:39:07 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 61A36610E5; Wed, 2 Jun 2021 14:37:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1622644643; bh=Ba1fJoC8PHQZgu+PPULsYm/Lb98b/hJDzMf9rPIQPf4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pNH2h+AN+6BEc/BuTwAg7ebeGDvP1IzS8/dwuw9WyemvRqLXvrO0rboW3BeYOrCRC A0x5ap3FiVFLypJl7Z3pkI+c8vsDBR15UziGnletDfGVJlZSHWbbUV8G55lfj/Egog Le3d3nYED4XwoCN9rIhgixCubhSJ5GUl5dTJGTGI= Date: Wed, 2 Jun 2021 16:37:21 +0200 From: Greg Kroah-Hartman To: Manikishan Ghantasala Cc: Alex Elder , Rui Miguel Silva , Johan Hovold , Alex Elder , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: greybus: fixed the coding style, labels should not be indented. Message-ID: References: <20210602133659.46158-1-manikishanghantasala@gmail.com> <9a3878fd-3b59-76f5-ddc7-625c66f9fee8@ieee.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 02, 2021 at 07:57:35PM +0530, Manikishan Ghantasala wrote: > Sending this mail again as I missed to reply to all. > Hi Alex, > > I agree those are called bit-field member names rather than labels. > But the reason I mentioned is because the ./scripts/checkpatch.pl > gave out a warning saying "labels should not be indented". checkpatch is a perl script that does it's best, but does not always get it right. In this case, it is incorrect, the existing code is just fine. thanks, greg k-h