[PATCH] staging: rtl8192u: fix coding-style issues in r8192U_hw.h

[PATCH] staging: rtl8192u: fix coding-style issues in r8192U_hw.h

[Manikishan Ghantasala]

staging: rtl8192u: r8192U_hw.h: Clear the coding-style issue

"Macros with complex values should be enclosed in parentheses"
by enclosing values in parantheses.
Modified spacing around "|" and removed a space before tab.

Signed-off-by: Manikishan Ghantasala <manikishanghantasala@gmail.com>
---
 drivers/staging/rtl8192u/r8192U_hw.h | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/rtl8192u/r8192U_hw.h b/drivers/staging/rtl8192u/r8192U_hw.h
index 8d3a592f1c35..27c96493006a 100644
--- a/drivers/staging/rtl8192u/r8192U_hw.h
+++ b/drivers/staging/rtl8192u/r8192U_hw.h
@@ -88,7 +88,7 @@ enum _RTL8192Usb_HW {
 #define RX_FIFO_THRESHOLD_MASK (BIT(13) | BIT(14) | BIT(15))
 #define RX_FIFO_THRESHOLD_SHIFT 13
 #define RX_FIFO_THRESHOLD_NONE 7
-#define MAX_RX_DMA_MASK 	(BIT(8) | BIT(9) | BIT(10))
+#define MAX_RX_DMA_MASK	(BIT(8) | BIT(9) | BIT(10))
 #define RCR_MXDMA_OFFSET	8
 #define RCR_FIFO_OFFSET		13
 #define RCR_ONLYERLPKT		BIT(31)			// Early Receiving based on Packet Size.
@@ -221,14 +221,13 @@ enum _RTL8192Usb_HW {
 #define	RATR_MCS14		0x04000000
 #define	RATR_MCS15		0x08000000
 // ALL CCK Rate
-#define RATE_ALL_CCK		RATR_1M|RATR_2M|RATR_55M|RATR_11M
-#define RATE_ALL_OFDM_AG	RATR_6M|RATR_9M|RATR_12M|RATR_18M|RATR_24M\
-							|RATR_36M|RATR_48M|RATR_54M
-#define RATE_ALL_OFDM_1SS	RATR_MCS0|RATR_MCS1|RATR_MCS2|RATR_MCS3 | \
-							RATR_MCS4|RATR_MCS5|RATR_MCS6|RATR_MCS7
-#define RATE_ALL_OFDM_2SS	RATR_MCS8|RATR_MCS9	|RATR_MCS10|RATR_MCS11| \
-							RATR_MCS12|RATR_MCS13|RATR_MCS14|RATR_MCS15
-
+#define RATE_ALL_CCK		(RATR_1M | RATR_2M | RATR_55M | RATR_11M)
+#define RATE_ALL_OFDM_AG	(RATR_6M | RATR_9M | RATR_12M | RATR_18M |\
+				 RATR_24M | RATR_36M | RATR_48M | RATR_54M)
+#define RATE_ALL_OFDM_1SS	(RATR_MCS0 | RATR_MCS1 | RATR_MCS2 | RATR_MCS3 |\
+				 RATR_MCS4 | RATR_MCS5 | RATR_MCS6 | RATR_MCS7)
+#define RATE_ALL_OFDM_2SS	(RATR_MCS8 | RATR_MCS9 | RATR_MCS10 | RATR_MCS11 |\
+				 RATR_MCS12 | RATR_MCS13 | RATR_MCS14 | RATR_MCS15)
 	EPROM_CMD		= 0xfe58,
 #define Cmd9346CR_9356SEL	BIT(4)
 #define EPROM_CMD_OPERATING_MODE_SHIFT 6
-- 
2.25.1

Re: [PATCH] staging: rtl8192u: fix coding-style issues in r8192U_hw.h

[Greg Kroah-Hartman]

On Wed, Jun 02, 2021 at 09:33:31PM +0530, Manikishan Ghantasala wrote:
> staging: rtl8192u: r8192U_hw.h: Clear the coding-style issue

Why is this line here?

> 
> "Macros with complex values should be enclosed in parentheses"
> by enclosing values in parantheses.

I can not understand this sentence, can you please reword it?

> Modified spacing around "|" and removed a space before tab.

This is not related to the first thing, please break this up into
multiple patches like the bot asked...

thanks,

greg k-h

Re: [PATCH] staging: rtl8192u: fix coding-style issues in r8192U_hw.h

[Manikishan Ghantasala]

On Wed, 2 Jun 2021 at 22:45, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Wed, Jun 02, 2021 at 09:33:31PM +0530, Manikishan Ghantasala wrote:
> > staging: rtl8192u: r8192U_hw.h: Clear the coding-style issue
>
> Why is this line here?
>
Added it as description and I put a break due to char limit.
> >
> > "Macros with complex values should be enclosed in parentheses"
> > by enclosing values in parantheses.
>
> I can not understand this sentence, can you please reword it?
>
I meant, I cleared(fixed) the error in quotes by enclosing them in parentheses.

> > Modified spacing around "|" and removed a space before tab.
>
> This is not related to the first thing, please break this up into
> multiple patches like the bot asked...
>
Okay, will do. Do I have to make one for the 'space before tab' too?
or can I ignore it?
> thanks,
>
> greg k-h


Thanks,
Manikishan Ghantasala

Re: [PATCH] staging: rtl8192u: fix coding-style issues in r8192U_hw.h

[Greg Kroah-Hartman]

On Wed, Jun 02, 2021 at 11:04:53PM +0530, Manikishan Ghantasala wrote:
> On Wed, 2 Jun 2021 at 22:45, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Wed, Jun 02, 2021 at 09:33:31PM +0530, Manikishan Ghantasala wrote:
> > > staging: rtl8192u: r8192U_hw.h: Clear the coding-style issue
> >
> > Why is this line here?
> >
> Added it as description and I put a break due to char limit.

Is that what existing patches for this driver looks like?

> > >
> > > "Macros with complex values should be enclosed in parentheses"
> > > by enclosing values in parantheses.
> >
> > I can not understand this sentence, can you please reword it?
> >
> I meant, I cleared(fixed) the error in quotes by enclosing them in parentheses.

Please describe this better in the changelog text.

> > > Modified spacing around "|" and removed a space before tab.
> >
> > This is not related to the first thing, please break this up into
> > multiple patches like the bot asked...
> >
> Okay, will do. Do I have to make one for the 'space before tab' too?
> or can I ignore it?

One patch per logical type of change.

thanks,

greg k-h

Re: [PATCH] staging: rtl8192u: fix coding-style issues in r8192U_hw.h

[Manikishan Ghantasala]

Hi Joe,
Thank you for the response, I am changing the mismatch with the real name.
Should I also prepare a new set of three patches separately as bot suggested?

Regards,
Manikishan Ghantasala
B.tech CSE
twitter | GitHub | amFOSS

On Wed, 2 Jun 2021 at 21:06, Joe Perches <joe@perches.com> wrote:
>
> On Wed, 2021-06-02 at 17:18 +0200, Greg Kroah-Hartman wrote:
> > On Wed, Jun 02, 2021 at 08:40:33PM +0530, sh4nnu wrote:
> > > staging: rtl8192u: r8192U_hw.h: Clear the coding-style issue
> > >
> > > "Macros with complex values should be enclosed in parantheses"
> > > by enclosing values in parantheses.
>
> parentheses
>
> > > Signed-off-by: sh4nnu <manikishanghantasala@gmail.com>
> []
> > - It looks like you did not use your "real" name for the patch on either
> >   the Signed-off-by: line, or the From: line (both of which have to
> >   match).  Please read the kernel file, Documentation/SubmittingPatches
> >   for how to do this correctly.
>
> Might be useful to have the patchbot script reduce the content of the
> message when it's identifiable.
>
> The patch itself looks OK.
>
>

Re: [PATCH] staging: rtl8192u: fix coding-style issues in r8192U_hw.h

[Joe Perches]

On Wed, 2021-06-02 at 17:18 +0200, Greg Kroah-Hartman wrote:
> On Wed, Jun 02, 2021 at 08:40:33PM +0530, sh4nnu wrote:
> > staging: rtl8192u: r8192U_hw.h: Clear the coding-style issue
> > 
> > "Macros with complex values should be enclosed in parantheses"
> > by enclosing values in parantheses.

parentheses

> > Signed-off-by: sh4nnu <manikishanghantasala@gmail.com>
[]
> - It looks like you did not use your "real" name for the patch on either
>   the Signed-off-by: line, or the From: line (both of which have to
>   match).  Please read the kernel file, Documentation/SubmittingPatches
>   for how to do this correctly.

Might be useful to have the patchbot script reduce the content of the
message when it's identifiable.

The patch itself looks OK.

Re: [PATCH] staging: rtl8192u: fix coding-style issues in r8192U_hw.h

[Greg Kroah-Hartman]

On Wed, Jun 02, 2021 at 08:40:33PM +0530, sh4nnu wrote:
> staging: rtl8192u: r8192U_hw.h: Clear the coding-style issue
> 
> "Macros with complex values should be enclosed in parantheses"
> by enclosing values in parantheses.
> Modified spacing around "|" and removed a space before tab.
> 
> Signed-off-by: sh4nnu <manikishanghantasala@gmail.com>
> ---
>  drivers/staging/rtl8192u/r8192U_hw.h | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/r8192U_hw.h b/drivers/staging/rtl8192u/r8192U_hw.h
> index 8d3a592f1c35..aabe03721d99 100644
> --- a/drivers/staging/rtl8192u/r8192U_hw.h
> +++ b/drivers/staging/rtl8192u/r8192U_hw.h
> @@ -88,7 +88,7 @@ enum _RTL8192Usb_HW {
>  #define RX_FIFO_THRESHOLD_MASK (BIT(13) | BIT(14) | BIT(15))
>  #define RX_FIFO_THRESHOLD_SHIFT 13
>  #define RX_FIFO_THRESHOLD_NONE 7
> -#define MAX_RX_DMA_MASK 	(BIT(8) | BIT(9) | BIT(10))
> +#define MAX_RX_DMA_MASK		(BIT(8) | BIT(9) | BIT(10))
>  #define RCR_MXDMA_OFFSET	8
>  #define RCR_FIFO_OFFSET		13
>  #define RCR_ONLYERLPKT		BIT(31)			// Early Receiving based on Packet Size.
> @@ -221,13 +221,13 @@ enum _RTL8192Usb_HW {
>  #define	RATR_MCS14		0x04000000
>  #define	RATR_MCS15		0x08000000
>  // ALL CCK Rate
> -#define RATE_ALL_CCK		RATR_1M|RATR_2M|RATR_55M|RATR_11M
> -#define RATE_ALL_OFDM_AG	RATR_6M|RATR_9M|RATR_12M|RATR_18M|RATR_24M\
> -							|RATR_36M|RATR_48M|RATR_54M
> -#define RATE_ALL_OFDM_1SS	RATR_MCS0|RATR_MCS1|RATR_MCS2|RATR_MCS3 | \
> -							RATR_MCS4|RATR_MCS5|RATR_MCS6|RATR_MCS7
> -#define RATE_ALL_OFDM_2SS	RATR_MCS8|RATR_MCS9	|RATR_MCS10|RATR_MCS11| \
> -							RATR_MCS12|RATR_MCS13|RATR_MCS14|RATR_MCS15
> +#define RATE_ALL_CCK		(RATR_1M | RATR_2M | RATR_55M | RATR_11M)
> +#define RATE_ALL_OFDM_AG	(RATR_6M | RATR_9M | RATR_12M | RATR_18M |\
> +				 RATR_24M | RATR_36M | RATR_48M | RATR_54M)
> +#define RATE_ALL_OFDM_1SS	(RATR_MCS0 | RATR_MCS1 | RATR_MCS2 | RATR_MCS3 |\
> +				 RATR_MCS4 | RATR_MCS5 | RATR_MCS6 | RATR_MCS7)
> +#define RATE_ALL_OFDM_2SS	(RATR_MCS8 | RATR_MCS9 | RATR_MCS10 | RATR_MCS11 |\
> +				 RATR_MCS12 | RATR_MCS13 | RATR_MCS14 | RATR_MCS15)
>  
>  	EPROM_CMD		= 0xfe58,
>  #define Cmd9346CR_9356SEL	BIT(4)
> -- 
> 2.25.1
> 
> 


Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch did many different things all at once, making it difficult
  to review.  All Linux kernel patches need to only do one thing at a
  time.  If you need to do multiple things (such as clean up all coding
  style issues in a file/driver), do it in a sequence of patches, each
  one doing only one thing.  This will make it easier to review the
  patches to ensure that they are correct, and to help alleviate any
  merge issues that larger patches can cause.

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what is needed in order to
  properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg,
  and everyone else, to know what this patch is all about.  Please read
  the section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what a proper Subject: line should
  look like.

- It looks like you did not use your "real" name for the patch on either
  the Signed-off-by: line, or the From: line (both of which have to
  match).  Please read the kernel file, Documentation/SubmittingPatches
  for how to do this correctly.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

[PATCH] staging: rtl8192u: fix coding-style issues in r8192U_hw.h

[sh4nnu]

staging: rtl8192u: r8192U_hw.h: Clear the coding-style issue

"Macros with complex values should be enclosed in parantheses"
by enclosing values in parantheses.
Modified spacing around "|" and removed a space before tab.

Signed-off-by: sh4nnu <manikishanghantasala@gmail.com>
---
 drivers/staging/rtl8192u/r8192U_hw.h | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/rtl8192u/r8192U_hw.h b/drivers/staging/rtl8192u/r8192U_hw.h
index 8d3a592f1c35..aabe03721d99 100644
--- a/drivers/staging/rtl8192u/r8192U_hw.h
+++ b/drivers/staging/rtl8192u/r8192U_hw.h
@@ -88,7 +88,7 @@ enum _RTL8192Usb_HW {
 #define RX_FIFO_THRESHOLD_MASK (BIT(13) | BIT(14) | BIT(15))
 #define RX_FIFO_THRESHOLD_SHIFT 13
 #define RX_FIFO_THRESHOLD_NONE 7
-#define MAX_RX_DMA_MASK 	(BIT(8) | BIT(9) | BIT(10))
+#define MAX_RX_DMA_MASK		(BIT(8) | BIT(9) | BIT(10))
 #define RCR_MXDMA_OFFSET	8
 #define RCR_FIFO_OFFSET		13
 #define RCR_ONLYERLPKT		BIT(31)			// Early Receiving based on Packet Size.
@@ -221,13 +221,13 @@ enum _RTL8192Usb_HW {
 #define	RATR_MCS14		0x04000000
 #define	RATR_MCS15		0x08000000
 // ALL CCK Rate
-#define RATE_ALL_CCK		RATR_1M|RATR_2M|RATR_55M|RATR_11M
-#define RATE_ALL_OFDM_AG	RATR_6M|RATR_9M|RATR_12M|RATR_18M|RATR_24M\
-							|RATR_36M|RATR_48M|RATR_54M
-#define RATE_ALL_OFDM_1SS	RATR_MCS0|RATR_MCS1|RATR_MCS2|RATR_MCS3 | \
-							RATR_MCS4|RATR_MCS5|RATR_MCS6|RATR_MCS7
-#define RATE_ALL_OFDM_2SS	RATR_MCS8|RATR_MCS9	|RATR_MCS10|RATR_MCS11| \
-							RATR_MCS12|RATR_MCS13|RATR_MCS14|RATR_MCS15
+#define RATE_ALL_CCK		(RATR_1M | RATR_2M | RATR_55M | RATR_11M)
+#define RATE_ALL_OFDM_AG	(RATR_6M | RATR_9M | RATR_12M | RATR_18M |\
+				 RATR_24M | RATR_36M | RATR_48M | RATR_54M)
+#define RATE_ALL_OFDM_1SS	(RATR_MCS0 | RATR_MCS1 | RATR_MCS2 | RATR_MCS3 |\
+				 RATR_MCS4 | RATR_MCS5 | RATR_MCS6 | RATR_MCS7)
+#define RATE_ALL_OFDM_2SS	(RATR_MCS8 | RATR_MCS9 | RATR_MCS10 | RATR_MCS11 |\
+				 RATR_MCS12 | RATR_MCS13 | RATR_MCS14 | RATR_MCS15)
 
 	EPROM_CMD		= 0xfe58,
 #define Cmd9346CR_9356SEL	BIT(4)
-- 
2.25.1