From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 812DFC4708F for ; Thu, 3 Jun 2021 02:45:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5BC27613F2 for ; Thu, 3 Jun 2021 02:45:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229675AbhFCCqr (ORCPT ); Wed, 2 Jun 2021 22:46:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229541AbhFCCqo (ORCPT ); Wed, 2 Jun 2021 22:46:44 -0400 Received: from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com [IPv6:2607:f8b0:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B12BBC06174A for ; Wed, 2 Jun 2021 19:44:44 -0700 (PDT) Received: by mail-oi1-x22d.google.com with SMTP id f30so3537562oij.7 for ; Wed, 02 Jun 2021 19:44:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ZZQYKNjkzbXDm9CIMxGhmOJ08FkC41qsAMnb0o1Bjxs=; b=RgmSNlHKZ4fxhOVgzUIKQnKC6KAXoEYn2tb6HQBdFU84JbJrOkZ5dz4BlNToJLPlKS mcF9s+xJzVC3oKtTR0TshLDyHMTrAogZ1+DlIJ+4Gu4wzhgAW2nYqsOjudeh/0Rcye7R P6lH7cd2Z0BgP/houfZYs3LAv1w7lR4Nj2mGj8Vao3+7x8QlrKAiRqtpJ7qhgD9l3WxE Z4UFAg4TFDt01v1w17duqgAQaJR9RTa993ESYgM5kqSCJoKSigvEUZi5bbiufFv4yvY2 h7aobkWFvg4wi6hHGNGNW9/HjPxE1Wc0LiAtBNrnJ0Bvr81akcULkAjUYq1QCcEMdPMA 6wcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZZQYKNjkzbXDm9CIMxGhmOJ08FkC41qsAMnb0o1Bjxs=; b=JBYpLTU1EN/fEJNGnjfO1E76dYv73Q1XQihyyiuv0yI9LBmCd+z9aMzFe3zooW4k4o odHQkh8+hGKqallWLDvhXzpkU1iKiaVh8hMhLOAj9Xbx3Ahm5vdhcSfCYfzbKxzWQG/a sZq1xiho5wg374QHPNCJhjXqKEsYtbXGDiSjnntOBkqLoARY+RwefKR8oxDrXh3O3jQ3 Qy9l2JgZjdqWFQoC9XQFnru8tqF1RFRew1b3QPXf8mqdY4btuggt9XvPj4SyGfeOvOQn 5Z6S/UGHAmwp4rqWRVkTWHmw6SMudDqdivwLuxDUwD6A/ywBG8GhMUavz1FP2ISIDrMr wyFg== X-Gm-Message-State: AOAM531XV+SMl9Anoib+6XOzsybzWMQr3M2e0kq64XC0PR1JLttDS121 cl6P5flp+FNRNbyRT5AA3aQ5cA== X-Google-Smtp-Source: ABdhPJw6sYb54WexwW6J95QUpKdekjtsw1V+SnInNWc6uSj7hBZ3jhLGszsEKSNzU3VDIM1bm7ldXg== X-Received: by 2002:aca:4bd6:: with SMTP id y205mr6134307oia.5.1622688283169; Wed, 02 Jun 2021 19:44:43 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id v8sm410008oiv.5.2021.06.02.19.44.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 19:44:42 -0700 (PDT) Date: Wed, 2 Jun 2021 21:44:40 -0500 From: Bjorn Andersson To: Stephen Boyd Cc: Maulik Shah , evgreen@chromium.org, mka@chromium.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, agross@kernel.org, dianders@chromium.org, linux@roeck-us.net, rnayak@codeaurora.org, lsrao@codeaurora.org, devicetree@vger.kernel.org Subject: Re: [PATCH v8 3/5] arm64: dts: qcom: sc7180: Enable SoC sleep stats Message-ID: References: <1621596371-26482-1-git-send-email-mkshah@codeaurora.org> <1621596371-26482-4-git-send-email-mkshah@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 02 Jun 19:26 CDT 2021, Stephen Boyd wrote: > Quoting Bjorn Andersson (2021-05-31 10:57:03) > > On Wed 26 May 18:30 CDT 2021, Stephen Boyd wrote: > > > > > Quoting Maulik Shah (2021-05-21 04:26:09) > > > > Add device node for SoC sleep stats driver which provides various > > > > low power mode stats. > > > > > > > > Also update the reg size of aoss_qmp device to 0x400. > > > > > > > > Cc: devicetree@vger.kernel.org > > > > Signed-off-by: Maulik Shah > > > > Reviewed-by: Bjorn Andersson > > > > --- > > > > arch/arm64/boot/dts/qcom/sc7180.dtsi | 7 ++++++- > > > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > > > index 6228ba2..889d04d 100644 > > > > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > > > > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > > > @@ -3215,7 +3215,7 @@ > > > > > > > > aoss_qmp: power-controller@c300000 { > > > > compatible = "qcom,sc7180-aoss-qmp"; > > > > - reg = <0 0x0c300000 0 0x100000>; > > > > + reg = <0 0x0c300000 0 0x400>; > > > > interrupts = ; > > > > mboxes = <&apss_shared 0>; > > > > > > > > @@ -3223,6 +3223,11 @@ > > > > #power-domain-cells = <1>; > > > > }; > > > > > > > > + rpmh-sleep-stats@c3f0000 { > > > > + compatible = "qcom,rpmh-sleep-stats"; > > > > + reg = <0 0x0c3f0000 0 0x400>; > > > > + }; > > > > + > > > > > > Does this need to be in DT? Can the sc7180-aoss-qmp driver use the > > > aux-bus and stick the sleep stats device on there? > > > > > > > The AOSS memory space has N chunks of "message ram", one is used for the > > QMP protocol (presumably the APSS specific one), a different one is used > > for the sleep stats. > > > > I presume we could have come up with a binding for the entire AOSS/AOP > > and then describe (either implicit or explicitly) the QMP and > > debug-stats under that. > > > > But we'd also have to come up with the same container-device for the RPM > > case. > > Because the rpm node doesn't include this region of memory today? I > still fail to see why we're changing the existing binding and adding a > DT node for this new region that is basically a debug feature. We're not changing the binding, the memory region for the "AOSS QMP" thing was never larger than 0x400. 0x100000 is the size of all the AOSS "msg_ram" regions. We don't have this whole thing described in a binding and we don't have an implementation for the whole thing. If we're going for that we'd need to extend the binding to indicate which of the msg_ram regions are used for APSS QMP and for debug stats on particular platform (either by compatible, explicit properties or as some subnodes). That said, as I looked into my other objection, for the RPM (non-hardened) case it seems that we're actually describing the RPM region. So there it would make sense to describe it as such in DT - but we don't have any other code (that I'm aware of) that would implement the "qcom,-rpm". Regards, Bjorn