From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57C37C07E94 for ; Fri, 4 Jun 2021 09:23:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 415F6610A2 for ; Fri, 4 Jun 2021 09:23:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230109AbhFDJZK (ORCPT ); Fri, 4 Jun 2021 05:25:10 -0400 Received: from mail-pg1-f181.google.com ([209.85.215.181]:35627 "EHLO mail-pg1-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229959AbhFDJZI (ORCPT ); Fri, 4 Jun 2021 05:25:08 -0400 Received: by mail-pg1-f181.google.com with SMTP id o9so4553055pgd.2 for ; Fri, 04 Jun 2021 02:23:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pcVIrrrWEUuSA+N6NdZCH+jzIyXyj1HQeo01ZwpdXxY=; b=T6vUk/4jMaY1sFB+ktO56Tu+hSYK1wiZBd79Qpkt7cR3wdk6RgqpEA+MqmoApExn4u Ki+XTdzY1lKdvlx+de9gaG+wdCW5+FLPTTH3w22d8er65zizi+PUDGgUHvaCEEPTouoT LUIBuV5Az0wlga/c+czm/LVkend9CKDw/kZwQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pcVIrrrWEUuSA+N6NdZCH+jzIyXyj1HQeo01ZwpdXxY=; b=R8RHgDPyofNMFT6ZI+ELOomlB/G7dSMXlLyTAA96YZ6TJrtWxkniwUkyH+UMBgOSWw YtQTDt+9DKwhGpat4eXnpYdKQtaGqVoSU2COvvjeBTT3WnFb5hc1gFk5w8G6qUzJhgrr mjreedonHZBGDElG+vSJE61S/baKsPxChg9ou3Xy+dDVrmcjT9EGSgZDMj7BU7yXZl0s L6TFjL9P3tRKTLdHn8LUKxUDnlSwhiomvN2F8G/XBenBMSQIXGPAcJ+fSn3OVu07T+lS FGlyj7c6+/4ZF0187BLCcS7OVD7qKIhlMDL1yy9oDMVxLHMDzgEbpaPoIUY6TsdbCYe2 JsNg== X-Gm-Message-State: AOAM531vxfDL7vSAttkQTJ8/191xRc+9D6/Nkv51u4KV39lQCn5MZkrw MiHsy0c6cT8NnT0427t7IToCzA== X-Google-Smtp-Source: ABdhPJyN+y7mCRzpjZlapAyCgZr6LbpUALEaLKem6t6vFwqQAQV8qZmVYl6DOYQnER784of3HxKE+Q== X-Received: by 2002:aa7:82cb:0:b029:2e6:f397:d248 with SMTP id f11-20020aa782cb0000b02902e6f397d248mr3647517pfn.52.1622798529641; Fri, 04 Jun 2021 02:22:09 -0700 (PDT) Received: from google.com ([2409:10:2e40:5100:36b:f5b6:c380:9ccf]) by smtp.gmail.com with ESMTPSA id d15sm4208168pjr.47.2021.06.04.02.22.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Jun 2021 02:22:09 -0700 (PDT) Date: Fri, 4 Jun 2021 18:22:02 +0900 From: Sergey Senozhatsky To: Paolo Bonzini Cc: Vitaly Kuznetsov , Sergey Senozhatsky , Marc Zyngier , Huacai Chen , Paul Mackerras , Christian Borntraeger , Suleiman Souhlal , x86@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-s390@vger.kernel.org, Sean Christopherson , Jim Mattson Subject: Re: [RFC][PATCH] kvm: add suspend pm-notifier Message-ID: References: <20210603164315.682994-1-senozhatsky@chromium.org> <87a6o614dn.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (21/06/04 09:24), Paolo Bonzini wrote: > On 04/06/21 09:21, Vitaly Kuznetsov wrote: > > > preempt_notifier_inc(); > > > + kvm_init_pm_notifier(kvm); > > You've probably thought it through and I didn't but wouldn't it be > > easier to have one global pm_notifier call for KVM which would go > > through the list of VMs instead of registering/deregistering a > > pm_notifier call for every created/destroyed VM? > > That raises questions on the locking, i.e. if we can we take the kvm_lock > safely from the notifier. Right, I wanted to take the VM lock, rather than subsystem lock (kvm_lock).