From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63C07C47099 for ; Fri, 4 Jun 2021 11:54:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4CFE361414 for ; Fri, 4 Jun 2021 11:54:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230321AbhFDL4k (ORCPT ); Fri, 4 Jun 2021 07:56:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:45998 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229682AbhFDL4g (ORCPT ); Fri, 4 Jun 2021 07:56:36 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3751561418; Fri, 4 Jun 2021 11:54:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1622807690; bh=wZZG/mGZCjQQr4cb050WrblT+FLO7Xb59hw5tKouVLo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=G4CIy+pqEcWSE8N1ou8T1exRmZ2BhmHAs5z1o5iTrbZso2KcXVcJnKtaxrVZeb9Ai AJYgJuj7XI7Zp0rUtT4oxLV3QBHNqimHQYnNeUUHmMRcLkJyo8mJEYodpTFODqI2Wj kiyUQV19SLATSESTWjh+tZIdmFuKfs5DejDBMNnE= Date: Fri, 4 Jun 2021 13:54:48 +0200 From: Greg KH To: Wesley Cheng Cc: balbi@kernel.org, agross@kernel.org, bjorn.andersson@linaro.org, robh+dt@kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, jackp@codeaurora.org, Thinh.Nguyen@synopsys.com Subject: Re: [PATCH v9 0/5] Re-introduce TX FIFO resize for larger EP bursting Message-ID: References: <1621410561-32762-1-git-send-email-wcheng@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1621410561-32762-1-git-send-email-wcheng@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 19, 2021 at 12:49:16AM -0700, Wesley Cheng wrote: > Changes in V9: > - Fixed incorrect patch in series. Removed changes in DTSI, as dwc3-qcom will > add the property by default from the kernel. This patch series has one build failure and one warning added: drivers/usb/dwc3/gadget.c: In function ‘dwc3_gadget_calc_tx_fifo_size’: drivers/usb/dwc3/gadget.c:653:45: warning: passing argument 1 of ‘dwc3_mdwidth’ makes pointer from integer without a cast [-Wint-conversion] 653 | mdwidth = dwc3_mdwidth(dwc->hwparams.hwparams0); | ~~~~~~~~~~~~~^~~~~~~~~~ | | | u32 {aka unsigned int} In file included from drivers/usb/dwc3/debug.h:14, from drivers/usb/dwc3/gadget.c:25: drivers/usb/dwc3/core.h:1493:45: note: expected ‘struct dwc3 *’ but argument is of type ‘u32’ {aka ‘unsigned int’} 1493 | static inline u32 dwc3_mdwidth(struct dwc3 *dwc) | ~~~~~~~~~~~~~^~~ drivers/usb/dwc3/dwc3-qcom.c: In function ‘dwc3_qcom_of_register_core’: drivers/usb/dwc3/dwc3-qcom.c:660:23: error: implicit declaration of function ‘of_add_property’; did you mean ‘of_get_property’? [-Werror=implicit-function-declaration] 660 | ret = of_add_property(dwc3_np, prop); | ^~~~~~~~~~~~~~~ | of_get_property How did you test these? thanks, greg k-h