From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66348C07E94 for ; Fri, 4 Jun 2021 13:06:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 427D061164 for ; Fri, 4 Jun 2021 13:06:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230153AbhFDNH7 (ORCPT ); Fri, 4 Jun 2021 09:07:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:45784 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229980AbhFDNH6 (ORCPT ); Fri, 4 Jun 2021 09:07:58 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CCA5C611AE; Fri, 4 Jun 2021 13:06:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622811972; bh=op6mFMNBOG5sNidlhmJKg6sGFjEf9a++1qcAfO/vUdo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=b5dQUcS8ebpyxCKDr/JxT8uLlfjXMnog4xZ0SA3Ts09HTgTLoFQr63FcQZSSr9Auo PL7DpQdV9U3/y/ApGZSs4ZUvk0y7GhAp3NhGY/e/8bKa4Q64uirMF5glGjfFXUJUEv WRMXYwhz+IqQ0N6RX+MyUoEFdl4mXM9ZVssaEiR+yMOuGtGq20d2MFJK4FScauFWtL DEC6TAa0GdDf6CnfClsC3vLV0yTjeAG9pcEp+NHkFJBh3UKGL92+TfZ1AQqVaEWqUF 0zDwyOG/AMOt/O3UdD6Luc0c7FiX5o3p+goOT05ZbBkAu90o9nqYZsEYIXqnsrDJMk N/NLdCh6hDYYA== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id F014240EFC; Fri, 4 Jun 2021 10:06:08 -0300 (-03) Date: Fri, 4 Jun 2021 10:06:08 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Namhyung Kim , Jiri Olsa , Ingo Molnar , Peter Zijlstra , Mark Rutland , Alexander Shishkin , LKML , Andi Kleen , Jin Yao Subject: Re: [PATCH 1/3] perf stat: Check return value of asprintf() properly Message-ID: References: <20210602212241.2175005-1-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Jun 03, 2021 at 09:47:58PM -0700, Ian Rogers escreveu: > On Wed, Jun 2, 2021 at 2:22 PM Namhyung Kim wrote: > > > > It returns -1 on error, so checking with 0 would not work. > > > > Fixes: 12279429d862 ("perf stat: Uniquify hybrid event name") > > Cc: Jin Yao > > Signed-off-by: Namhyung Kim > > Acked-by: Ian Rogers Thanks, applied both. - Arnaldo > Thanks, > Ian > > > --- > > tools/perf/util/stat-display.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c > > index b759dfd633b4..04afd41b6067 100644 > > --- a/tools/perf/util/stat-display.c > > +++ b/tools/perf/util/stat-display.c > > @@ -564,7 +564,7 @@ static void uniquify_event_name(struct evsel *counter) > > counter->name, counter->pmu_name); > > } > > > > - if (ret) { > > + if (ret > 0) { > > free(counter->name); > > counter->name = new_name; > > } > > -- > > 2.32.0.rc0.204.g9fa02ecfa5-goog > > -- - Arnaldo