From: Greg KH <greg@kroah.com>
To: Tony Lindgren <tony@atomide.com>
Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Keerthy <j-keerthy@ti.com>, Tero Kristo <kristo@kernel.org>
Subject: Re: [Backport for linux-5.4.y PATCH 2/4] ARM: OMAP2+: Prepare timer code to backport dra7 timer wrap errata i940
Date: Wed, 9 Jun 2021 08:22:27 +0200 [thread overview]
Message-ID: <YMBeI4aOMmWMRsu/@kroah.com> (raw)
In-Reply-To: <YMBcIbBPfr6W19j5@atomide.com>
On Wed, Jun 09, 2021 at 09:13:53AM +0300, Tony Lindgren wrote:
> Hi,
>
> * Greg KH <greg@kroah.com> [210608 17:13]:
> > On Wed, Jun 02, 2021 at 01:46:23PM +0300, Tony Lindgren wrote:
> > > Prepare linux-5.4.y to backport upstream timer wrap errata commit
> > > 3efe7a878a11c13b5297057bfc1e5639ce1241ce and commit
> > > 25de4ce5ed02994aea8bc111d133308f6fd62566. Earlier kernels still use
> > > mach-omap2/timer instead of drivers/clocksource as these kernels still
> > > depend on legacy platform code for timers. Note that earlier stable
> > > kernels need also additional patches and will be posted separately.
> >
> > I do not understand this paragraph.
> >
> > What upstream commit is this? And "posted separately" shouldn't show up
> > in a changelog text, right?
>
> This would be a partial backport to add struct dmtimer_clockevent from
> commit 52762fbd1c4778ac9b173624ca0faacd22ef4724 to the platform timer
> code used in the older kernels.
>
> How about the following for the description:
>
> Upstream commit 52762fbd1c4778ac9b173624ca0faacd22ef4724 usage of
> struct dmtimer_clockevent backported to the platform timer code
> still used in linux-5.4.y stable kernel. Needed to backport upstream
> commit 3efe7a878a11c13b5297057bfc1e5639ce1241ce and commit
> 25de4ce5ed02994aea8bc111d133308f6fd62566. Earlier kernels use
> mach-omap2/timer instead of drivers/clocksource as these kernels still
> depend on legacy platform code for booting.
Why are you combining 2 commits into one here?
I do not understand what this commit really is at all still, sorry.
How about just providing backports for the individual commits, do not
combine them as that just is a mess.
> > Can you fix this up to make this obvious what is happening here and make
> > a patch series that I can take without editing changelog text?
>
> Sure I'll repost the series, assuming the above is OK for description :)
> Please let me know if you need further details added.
>
> Hmm so what's the correct way to prevent automatically applying these
> into the earlier stable kernels?
What would cause them to be automatically applied? You need to let us
know what kernel(s) they should go to.
thanks,
greg k-h
next prev parent reply other threads:[~2021-06-09 6:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 10:46 [Backport for linux-5.4.y PATCH 1/4] ARM: OMAP: replace setup_irq() by request_irq() Tony Lindgren
2021-06-02 10:46 ` [Backport for linux-5.4.y PATCH 2/4] ARM: OMAP2+: Prepare timer code to backport dra7 timer wrap errata i940 Tony Lindgren
2021-06-08 17:13 ` Greg KH
2021-06-09 6:13 ` Tony Lindgren
2021-06-09 6:22 ` Greg KH [this message]
2021-06-09 6:58 ` Tony Lindgren
2021-06-09 7:31 ` Greg KH
2021-06-09 8:50 ` Tony Lindgren
2021-06-02 10:46 ` [Backport for linux-5.4.y PATCH 3/4] ARM: OMAP2+: Prepare to handle dra7 timer wrap issue Tony Lindgren
2021-06-02 10:46 ` [Backport for linux-5.4.y PATCH 4/4] ARM: OMAP2+: Handle dra7 timer wrap errata i940 Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMBeI4aOMmWMRsu/@kroah.com \
--to=greg@kroah.com \
--cc=daniel.lezcano@linaro.org \
--cc=j-keerthy@ti.com \
--cc=kristo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).