From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Jiri Slaby <jirislaby@kernel.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>
Subject: Re: [PATCH v1 2/3] serial: 8250_exar: Extract exar_get_platform() helper
Date: Wed, 9 Jun 2021 20:02:17 +0300 [thread overview]
Message-ID: <YMD0GZdbwICgmSmA@smile.fi.intel.com> (raw)
In-Reply-To: <YMC3AhYbxA0Nbp8q@kroah.com>
On Wed, Jun 09, 2021 at 02:41:38PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Jun 08, 2021 at 05:42:38PM +0300, Andy Shevchenko wrote:
> > We would like to use DMI matching in other functions as well.
> > Hence, extract it as exar_get_platform() helper function.
> Do not mix "fixes with features" in a single series, as I now have to
> pick it apart and apply it to different branches by hand :(
>
> Please do different series for the two different things if at all
> possible.
I see. Thank you for pointing out, I will keep in mind for the future submissions.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-06-09 17:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 14:42 [PATCH v1 1/3] serial: 8250_exar: Avoid NULL pointer dereference at ->exit() Andy Shevchenko
2021-06-08 14:42 ` [PATCH v1 2/3] serial: 8250_exar: Extract exar_get_platform() helper Andy Shevchenko
2021-06-09 12:41 ` Greg Kroah-Hartman
2021-06-09 17:02 ` Andy Shevchenko [this message]
2021-06-08 14:42 ` [PATCH v1 3/3] serial: 8250_exar: Add ->unregister_gpio() callback Andy Shevchenko
2021-06-09 12:42 ` Greg Kroah-Hartman
2021-06-08 15:09 ` [PATCH v1 1/3] serial: 8250_exar: Avoid NULL pointer dereference at ->exit() Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMD0GZdbwICgmSmA@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).