From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5FC6C48BCF for ; Wed, 9 Jun 2021 15:36:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9CA1661285 for ; Wed, 9 Jun 2021 15:36:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234062AbhFIPi3 (ORCPT ); Wed, 9 Jun 2021 11:38:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232474AbhFIPi0 (ORCPT ); Wed, 9 Jun 2021 11:38:26 -0400 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BEFF4C061574; Wed, 9 Jun 2021 08:36:29 -0700 (PDT) Received: by mail-pf1-x435.google.com with SMTP id q25so18668359pfh.7; Wed, 09 Jun 2021 08:36:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=neZ2e107rW6u5+BVpWqPAvfyZBtmzgP4djPpeqRyQ04=; b=p3oEZTsxgUaXISabfNCfwlDjRW2XZRlWVv0TCVqelJkHJNM3/EWJSwsue6tjO4/hhn /vfNCoDxpC6LKITX/NHS/uCxfh+V81P01S14Ux2ihYwvi4a1qnhCxbdaRZR0jv5VBvbi hbUFaLZ/uic5TZYxY6VhezmmWDxp+UqJiwAD8WYYjHJw0KqJYn4RK4RvLppFNGu6LjAW caaZ7rG/9S5XC2gNOEnbbDa8h79L/6/RGaWH0OezCFC/+2HVQ7I4gDWY1Oy0b2KM+Fhy cND97zONfQd+t3dc0lti732r5qaX34Uf33Qtn2mMRUWrtTJl/us2WvKy2aPm6FXKTxzV FzmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=neZ2e107rW6u5+BVpWqPAvfyZBtmzgP4djPpeqRyQ04=; b=uBimOsYnj+cj4iqVwerh/EmfhsFygBcoPZsBGa1cuJacbg3gkMKgGYmdoK3QSZlOxc qPuwyYW7uqSZgBDKX9SUoTsakKFLlrrn5Vzb4H+xFuZMLU2HyGt8Ukth3YMdmr/MjlFA QDpk+cAHkiVzArbUd3Ah/dUn984NeYYYgzExutleITo8IalVdJ2zVOmgP8ZMTWeSvOOY gyKkypJEwnVPvbhVCOyLUgtAjRyRTDOiWO9Rq1xpg1uqWRovxfUs2EwDkw6UI+Ja4Tnq 1ZhGFpzZyxwUukR7BbP7UXLL7by21WSV5QLBhb5xu323q3GCpTTlQtkrjhQ/HfkYQxar j2Gw== X-Gm-Message-State: AOAM5330mz+dblCDmUSTictRsXtW8TlZ2fzOF1LKi30+vHPNXWcNsMR1 4KO+MAvqm622FStnzFsYyG4= X-Google-Smtp-Source: ABdhPJwyxxyPeyzTzDbknC8LuuZIDpubLWJAJOncQpZ+ccwe7qvp01K7EbRKkr59WznDo/R+ekfEDg== X-Received: by 2002:a63:ad0f:: with SMTP id g15mr248776pgf.415.1623252989343; Wed, 09 Jun 2021 08:36:29 -0700 (PDT) Received: from shinobu ([156.146.35.76]) by smtp.gmail.com with ESMTPSA id u12sm50028pfm.2.2021.06.09.08.36.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jun 2021 08:36:28 -0700 (PDT) Date: Thu, 10 Jun 2021 00:36:22 +0900 From: William Breathitt Gray To: o.rempel@pengutronix.de Cc: linux-stm32@st-md-mailman.stormreply.com, kernel@pengutronix.de, a.fatoum@pengutronix.de, kamel.bouhara@bootlin.com, gwendal@chromium.org, alexandre.belloni@bootlin.com, david@lechnology.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, syednwaris@gmail.com, patrick.havelange@essensium.com, fabrice.gasnier@st.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, Jonathan Cameron , jarkko.nikula@linux.intel.com Subject: Re: [PATCH v11 14/33] counter: interrupt-cnt: Add const qualifier for actions_list array Message-ID: References: <20210609162942.6bdc6d63@jic23-huawei> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bM5rh64AbDYaJ0MC" Content-Disposition: inline In-Reply-To: <20210609162942.6bdc6d63@jic23-huawei> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --bM5rh64AbDYaJ0MC Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 09, 2021 at 04:29:42PM +0100, Jonathan Cameron wrote: > On Wed, 9 Jun 2021 10:31:17 +0900 > William Breathitt Gray wrote: >=20 > > The struct counter_synapse actions_list member expects a const enum > > counter_synapse_action array. This patch adds the const qualifier to the > > interrupt_cnt_synapse_actionss to match actions_list. > >=20 > > Cc: Oleksij Rempel > > Signed-off-by: William Breathitt Gray > Naming looks unusual... >=20 > > --- > > drivers/counter/interrupt-cnt.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/drivers/counter/interrupt-cnt.c b/drivers/counter/interrup= t-cnt.c > > index 827d785e19b4..0e07607f2cd3 100644 > > --- a/drivers/counter/interrupt-cnt.c > > +++ b/drivers/counter/interrupt-cnt.c > > @@ -77,7 +77,7 @@ static const struct counter_count_ext interrupt_cnt_e= xt[] =3D { > > }, > > }; > > =20 > > -static enum counter_synapse_action interrupt_cnt_synapse_actionss[] = =3D { > > +static const enum counter_synapse_action interrupt_cnt_synapse_actions= s[] =3D { >=20 > actions? >=20 > Perhaps good to fix that whilst we are here. >=20 > > COUNTER_SYNAPSE_ACTION_RISING_EDGE, > > }; > > =20 Hi Oleksij, Would you take a look at this driver and let us know whether the two 's' at the end of this symbol is intentional? Thanks, William Breathitt Gray --bM5rh64AbDYaJ0MC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEk5I4PDJ2w1cDf/bghvpINdm7VJIFAmDA3+UACgkQhvpINdm7 VJJDog/7BWfRthJW0ybnlLsxDyqpvnBx92k2hiBaXR2DX8siYjVeWomh7OpLXzwf C84Ze4rdn8H6/Dpc3wA8vDiUUHX9VwIcACOpOh2KJ2IoF5AdrOzLjS9b+a+ZFusC mpbvfXz6/VxKgqjQY8JY+dgTFiROGNnJrllDaCV1sNPRPa/WwmGVSgh8b/+UMeBd e3QOQ5JG77FfWwzV0jjSw9Tq1e7fr+qbtg0v0Nvz74AGePCEsetIxQyA13HWyaEP qlMDIi0yrsbveBx+uUyhJ64hulLu9xRLuGFdtvdICP+b8WohDzykuVTPqHk4z9Ki hNTDtA7qZIZTDlBMVlC3XNGiEfd/B5CIktmatlQVmDmpOF/FaJmF/UyUFXJxG+IE ZH7AuxS8lNtxetA/AAM8ED82WJZ2BWLPW6OZc1HUt41r2eJNsqeCA/fCzrvdEeHg FcSnqxuAwWI9TZ4w1jiaiVTV6N4Z4aNsH9uoX4MSHp/y0obm1hQh2tBZc55DG1Nn 0skswdQVV8k5mjJO4fTMZF8H9N+026UpRZ8bnoO7XkeIs39sPSSmVJo6r3ZDoxiL Rlsd3zp2ByCk5+DfeZLaBCpNWwwndrx2SSq/EN9pKDq3OnkwXs37T8Arql2zfP31 xaeIQUCVKnZE3q7xJV+4EL38BTDw1n8QzrLylft6fViv6xNVAR8= =0g9k -----END PGP SIGNATURE----- --bM5rh64AbDYaJ0MC--