From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE7CEC48BDF for ; Thu, 10 Jun 2021 06:49:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B3731613CA for ; Thu, 10 Jun 2021 06:49:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230055AbhFJGvK (ORCPT ); Thu, 10 Jun 2021 02:51:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:46162 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229634AbhFJGvF (ORCPT ); Thu, 10 Jun 2021 02:51:05 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9A418613CA; Thu, 10 Jun 2021 06:49:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623307749; bh=iIkVGEdZ6nVOvPq75U9lbg5Ox4Vh5/72oUnE/OZA/bc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QB4gOl+EsIvP5QsweNEAYkLbiEjI3pWQwjomUchuL2PfwIp/zEtOjKbE9F2hlDdpX OmIKO0TbL/jsB/pJK6Oov3SCFutZZ4NqXnSRZ4dnaFVrFBJHMBdUCLS/zT+0IIMZND ULdlWuTbv+5ZUMshzIzBvnv4KIlFDhWAaQ+kfJRs= Date: Thu, 10 Jun 2021 08:49:06 +0200 From: 'Greg Kroah-Hartman' To: linyyuan@codeaurora.org Cc: 'Felipe Balbi' , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] usb: gadget: eem: fix command packet transfer issue Message-ID: References: <000201d75dbf$58d1cc40$0a7564c0$@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <000201d75dbf$58d1cc40$0a7564c0$@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 10, 2021 at 02:10:40PM +0800, linyyuan@codeaurora.org wrote: > From: Linyu Yuan > > there is following warning, > [] dwc3_gadget_ep_queue+0x1b4/0x1c8 > [] usb_ep_queue+0x3c/0x120 > [] eem_unwrap+0x180/0x330 > [] rx_complete+0x70/0x230 > [] usb_gadget_giveback_request+0x3c/0xe8 > [] dwc3_gadget_giveback+0xb4/0x190 > [] dwc3_endpoint_transfer_complete+0x32c/0x410 > [] dwc3_bh_work+0x654/0x12e8 > [] process_one_work+0x1d4/0x4a8 > [] worker_thread+0x50/0x4a8 > [] kthread+0xe8/0x100 > [] ret_from_fork+0x10/0x50 > request ffffffc0716bf200 belongs to 'ep0out' > > when gadget receive a eem command packet from host, it need to response, > but queue usb request to wrong endpoint. > fix it by queue usb request to eem IN endpoint and allow host read it. > > Cc: stable > Signed-off-by: Linyu Yuan > --- > drivers/usb/gadget/function/f_eem.c | 44 > ++++++++++++++++++++++++++++++++----- Your patch is line-wrapped and can not be applied :( Please fix your email client to properly send patches correctly. thanks, greg k-h