From: Johan Hovold <johan@kernel.org>
To: Stefan Agner <stefan@agner.ch>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: serial: cp210x: Fix alternate function for CP2102N QFN20
Date: Thu, 10 Jun 2021 09:53:44 +0200 [thread overview]
Message-ID: <YMHFCNbTAHxPDmqv@hovoldconsulting.com> (raw)
In-Reply-To: <51830b2b24118eb0f77c5c9ac64ffb2f519dbb1d.1622218300.git.stefan@agner.ch>
On Fri, May 28, 2021 at 10:39:31PM +0200, Stefan Agner wrote:
> The QFN20 part has a different GPIO/port function assignment. The
> configuration struct bit field ordered as TX/RX/RS485/WAKEUP/CLK
> which exactly matches GPIO0-3 for QFN24/28. However, QFN20 has a
> different GPIO to primary function assignment.
>
> Special case QFN20 to follow to properly detect which GPIOs are
> available.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> Tested on a custom PCB with a CP2102N QFP20 device. I noticed the bug after
> configuring GPIO.2/3 to be TX/RX LED.
Thanks for fixing this, Stefan.
Nice and clean and patch, and your findings match the datasheet ("Table
4.2. GPIO Pin Alternate Functions").
Now applied for 5.13 with a stable tag.
Johan
prev parent reply other threads:[~2021-06-10 7:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 20:39 [PATCH] USB: serial: cp210x: Fix alternate function for CP2102N QFN20 Stefan Agner
2021-06-10 7:53 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMHFCNbTAHxPDmqv@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).