From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2617EC48BDF for ; Thu, 10 Jun 2021 14:02:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0F11E6109E for ; Thu, 10 Jun 2021 14:02:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231297AbhFJOEG (ORCPT ); Thu, 10 Jun 2021 10:04:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:34828 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231261AbhFJOEF (ORCPT ); Thu, 10 Jun 2021 10:04:05 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A839E6109E; Thu, 10 Jun 2021 14:01:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623333715; bh=yrLAXXvUeS68GMJbgtmovi+jlNOK0o/BU4Tl7w2FEKw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nXFOXgEZ2ID7f6vJvZlzP+G+ZJOggPvOgfsTTe7ByEEWlPVVL3A67BMTaMvi1MIAN s9k9T1uTjSwN6o33WtFIA2v+Ag2YbSJ1QUcbo4elpP7np1zfSXIEwS83EIQIUQh0ey LjrHPvsu3bVAgnNeB1DOg0fAnirKg/j1yp6wG+7s= Date: Thu, 10 Jun 2021 16:01:52 +0200 From: "gregkh@linuxfoundation.org" To: Mathias Nyman Cc: "Zhangjiantao (Kirin, nanjing)" , "Xuetao (kirin)" , "mathias.nyman@intel.com" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "chenyu (U)" , Caiyadong , xuhaiyang Subject: Re: [PATCH] xhci: solve a double free problem while doing s4 Message-ID: References: <1623244292-108534-1-git-send-email-xuetao09@huawei.com> <1428e2d7b7b74fccb3493384f96c521a@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 10, 2021 at 04:45:54PM +0300, Mathias Nyman wrote: > On 9.6.2021 17.22, Zhangjiantao (Kirin, nanjing) wrote: > > when system is doing s4, the process of xhci_resume may be as below: > > 1、xhci_mem_cleanup > > 2、xhci_init->xhci_mem_init->xhci_mem_cleanup(when memory is not enough). > > xhci_mem_cleanup will be executed twice when system is out of memory. > > xhci->port_caps is freed in xhci_mem_cleanup,but it isn't set to NULL. > > It will be freed twice when xhci_mem_cleanup is called the second time. > > > > Thanks, nice catch > > > We got following bug when system resumes from s4: > > > > kernel BUG at mm/slub.c:309! > > Internal error: Oops - BUG: 0 [#1] PREEMPT SMP > > CPU: 0 PID: 5929 Tainted: G S W 5.4.96-arm64-desktop #1 > > pc : __slab_free+0x5c/0x424 > > lr : kfree+0x30c/0x32c > > > > Call trace: > > __slab_free+0x5c/0x424 > > kfree+0x30c/0x32c > > xhci_mem_cleanup+0x394/0x3cc > > xhci_mem_init+0x9ac/0x1070 > > xhci_init+0x8c/0x1d0 > > xhci_resume+0x1cc/0x5fc > > xhci_plat_resume+0x64/0x70 > > platform_pm_thaw+0x28/0x60 > > dpm_run_callback+0x54/0x24c > > device_resume+0xd0/0x200 > > async_resume+0x24/0x60 > > async_run_entry_fn+0x44/0x110 > > process_one_work+0x1f0/0x490 > > worker_thread+0x5c/0x450 > > kthread+0x158/0x160 > > ret_from_fork+0x10/0x24 > > > > Signed-off-by: Tao Xue > > Checkpatch complains: > ERROR: Missing Signed-off-by: line by nominal patch author 'Zhangjiantao (Kirin, nanjing) ' > > Is Zhangjiantao (Kirin, nanjing) the correct author? If yes can I add > "Signed-off-by: Zhangjiantao (Kirin, nanjing) ? Please note that it is generally a bad thing for others to add someone else's s-o-b line, as it is a legal agreement. It is best for them to send it instead. thanks, greg k-h