From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AAE7C48BD1 for ; Thu, 10 Jun 2021 17:29:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4E4E1601FD for ; Thu, 10 Jun 2021 17:29:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230368AbhFJRbs (ORCPT ); Thu, 10 Jun 2021 13:31:48 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:48980 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229823AbhFJRbr (ORCPT ); Thu, 10 Jun 2021 13:31:47 -0400 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 42A4E8D4; Thu, 10 Jun 2021 19:29:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1623346190; bh=cZQIFk8YpbbL4ULk6qHhuB1oz8HLYuTilOZ34lpbSNw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RXfwJXK9YLwtsV1Nh4tKqxmV/RDka5glJhQKpvegKKC6iGJXllsjvbDw/DQd5WFhw 2imuTiYlSxwwrAsxBD2H+xEsQ38RmR5Km0LdqNBGzPj1kZhhzVwOs8t4nTwSBb9WM3 DjI1pgwZdb11oCJUYkbqGL0xbIbquNxKcdGDVEJc= Date: Thu, 10 Jun 2021 20:29:31 +0300 From: Laurent Pinchart To: Ricardo Ribalda Cc: Mauro Carvalho Chehab , Hans Verkuil , Sergey Senozhatsky , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, tfiga@chromium.org, Mike Isely Subject: Re: [PATCH v9 02/22] media: pvrusb2: Do not check for V4L2_CTRL_WHICH_DEF_VAL Message-ID: References: <20210326095840.364424-1-ribalda@chromium.org> <20210326095840.364424-3-ribalda@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210326095840.364424-3-ribalda@chromium.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ricardo, Thank you for the patch. On Fri, Mar 26, 2021 at 10:58:20AM +0100, Ricardo Ribalda wrote: > The framework already checks for us if V4L2_CTRL_WHICH_DEF_VAL is > written. > > Cc: Mike Isely > Signed-off-by: Ricardo Ribalda > Reviewed-by: Hans Verkuil Reviewed-by: Laurent Pinchart > --- > drivers/media/usb/pvrusb2/pvrusb2-v4l2.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c b/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c > index 9657c1883311..c04ab7258d64 100644 > --- a/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c > +++ b/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c > @@ -640,10 +640,6 @@ static int pvr2_s_ext_ctrls(struct file *file, void *priv, > unsigned int idx; > int ret; > > - /* Default value cannot be changed */ > - if (ctls->which == V4L2_CTRL_WHICH_DEF_VAL) > - return -EINVAL; > - > ret = 0; > for (idx = 0; idx < ctls->count; idx++) { > ctrl = ctls->controls + idx; -- Regards, Laurent Pinchart