From: Jiri Olsa <firstname.lastname@example.org>
To: Steven Rostedt <email@example.com>
Cc: Ian Rogers <firstname.lastname@example.org>,
Peter Zijlstra <email@example.com>,
Ingo Molnar <firstname.lastname@example.org>,
Arnaldo Carvalho de Melo <email@example.com>,
Mark Rutland <firstname.lastname@example.org>,
Alexander Shishkin <email@example.com>,
Namhyung Kim <firstname.lastname@example.org>,
Tzvetomir Stoyanov <email@example.com>,
firstname.lastname@example.org, Michael Petlan <email@example.com>
Subject: Re: [RFC PATCH] libtraceevent: Increase libtraceevent logging when verbose
Date: Thu, 10 Jun 2021 21:08:32 +0200 [thread overview]
Message-ID: <YMJjMPDKo2IdCC6G@krava> (raw)
On Thu, Jun 10, 2021 at 10:39:27AM -0400, Steven Rostedt wrote:
> On Wed, 9 Jun 2021 23:06:43 -0700
> Ian Rogers <firstname.lastname@example.org> wrote:
> > libtraceevent has added more levels of debug printout and with changes
> > like:
> > https://email@example.com
> > previously generated output like "registering plugin" is no longer
> > displayed. This change makes it so that if perf's verbose debug output
> > is enabled then the debug and info libtraceevent messages can be
> > displayed.
> > As this API isn't present in the deprecated tools version of
> > libtracevent I'm uploading this as an RFC.
> Thanks Ian,
> We need to start porting perf to using the upstream libtraceevent
> library. I think the best way to do that is what we did with trace-cmd.
> That is to have the make files check if the minimum version of
> libtraceevent is installed, and if so, use that instead of the local
> version. If it is not installed, produce a message encouraging the
> developer to install the upstream libtraceevent and warn that it will
> be using a deprecated older versino, then build the deprecated local
> version. After some time, we could simply remove it and make it a
> dependency, but I want to do that when all the main distros being used
> have it.
Michael did the libtraceevent detection and dynamic linking support:
I think we should have that in Fedora/RHEL rpms already, or it's on the way.
The detection code could be change to contain things we need.
> Currently its in the latest Debian, Ubuntu, and Fedora. I also believe
> its in SUSE but have not checked. It's in Fedora 34, but it doesn't
> appear to be in Fedora 33. As that's not too old, I don't think we
> should make it a dependency as of yet.
> -- Steve
next prev parent reply other threads:[~2021-06-10 19:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 6:06 [RFC PATCH] libtraceevent: Increase libtraceevent logging when verbose Ian Rogers
2021-06-10 14:39 ` Steven Rostedt
2021-06-10 18:50 ` Ian Rogers
2021-06-10 19:32 ` Steven Rostedt
2021-06-10 19:08 ` Jiri Olsa [this message]
2021-06-10 19:47 ` Steven Rostedt
2021-06-10 19:59 ` Steven Rostedt
2021-06-10 20:47 ` Jiri Olsa
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).