From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFC49C48BDF for ; Thu, 10 Jun 2021 22:57:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CE469613FF for ; Thu, 10 Jun 2021 22:57:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230409AbhFJW70 (ORCPT ); Thu, 10 Jun 2021 18:59:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:43512 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230001AbhFJW7Z (ORCPT ); Thu, 10 Jun 2021 18:59:25 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E79A6613E1; Thu, 10 Jun 2021 22:57:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623365849; bh=2qdiKDsyqPFhDYPrvVgVTKvPw/sEvqf7zh726VLz6oY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p4QOnH+iB2+HQX/xjqiXTm6GkBuwf0HXl0tubPc4tqIchX5M/JPj+0aXJc4H1dRc6 iHWYY3W8LfE5UR7maDeWIoS6+BDG9TL7DGJJg6qkreFBER7x77XoctmWwnojk2UFTn CWszSxnOAGk9zOy+uPvvMeBKFVAwEhMD0Bmf3K7ZGcRSSN2XGBZ2lBo68IqOYOGt5N aJWUBo+VrJ+mMlsxJ1pGQviVSJ7lgBZJORUm/c+fp+1rm+Z4Zf0oNPPW9fNKeplWxP OlDA9s+Uw9M/4C3csHao6xW3id36sDPefwShQ0sD4KNpbO1xMCcc1pXBa7RxF8EQN3 HTXjdy0o2gCeg== Date: Thu, 10 Jun 2021 15:57:27 -0700 From: Eric Biggers To: Chao Yu Cc: jaegeuk@kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH v2] f2fs: introduce f2fs_casefold_name slab cache Message-ID: References: <20210608000022.5509-1-chao@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210608000022.5509-1-chao@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 08, 2021 at 08:00:22AM +0800, Chao Yu wrote: > From: Chao Yu > > Add a slab cache: "f2fs_casefold_name" for memory allocation > of casefold name. Commit message should say "f2fs_casefolded_name", not "f2fs_casefold_name". > Signed-off-by: Chao Yu > --- > v2: > - change slab cache name to "f2fs_casefolded_name" > - add a "f2fs_" prefix for slab cache variable name > fs/f2fs/dir.c | 17 +++++++++++------ > fs/f2fs/recovery.c | 6 +++++- > fs/f2fs/super.c | 24 ++++++++++++++++++++++++ Otherwise this looks good. Reviewed-by: Eric Biggers - Eric