From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4ED4C48BE0 for ; Fri, 11 Jun 2021 03:01:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD8FD6139A for ; Fri, 11 Jun 2021 03:01:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231246AbhFKDDC (ORCPT ); Thu, 10 Jun 2021 23:03:02 -0400 Received: from mail-ot1-f54.google.com ([209.85.210.54]:47012 "EHLO mail-ot1-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231180AbhFKDDB (ORCPT ); Thu, 10 Jun 2021 23:03:01 -0400 Received: by mail-ot1-f54.google.com with SMTP id 66-20020a9d02c80000b02903615edf7c1aso1751097otl.13 for ; Thu, 10 Jun 2021 20:00:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=9elBhRYRohBJLYXGAbC8/QtueNh7yhzWwdc2SlWJcOU=; b=vegh8wsiAC+x1bVv8y3kjhUeGWh9t2LfpIXlFUh1fR7KFxkonHV4/EpbnYFyNJG7A/ 2S3+EdWpeDLbwZLpyPxeVdyla/rZijDPnQIK69FHteGtdP3mQv43s391Q7DJX1aiOLac S1YTiMwgrKzdu5xgDfcYnkdKSwKxPq5UmWtUV2LnVwBnYbhKlOaJReXdtkFp/f3UVGGd LJHHoiWY08rqK+q1ymjI0WbynAP/P0fCynmb+h/S5hdQ0WiRCf5nvZwkZnsgzcRzTtXq TnS9tECmSNSatPkOpPoNWoWUyIXw0ft+6kJIHOE3Pyfr3QHrMJKkI6IBeFULSnJ7MxKY baIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9elBhRYRohBJLYXGAbC8/QtueNh7yhzWwdc2SlWJcOU=; b=Y4It+mP03xfZqXXMgp5jv78uk9fqxFemQGyxyfCEuCKgRQ3jaSGAM3nJp51Ndgbg5W WQDBfsFcyDKT9Pb4kCaxEUgYS68413RrpJi3nUPe5nLJssBZuCi6lodCEsftmQPC8V/r eIGfkj8+PMErLmVjwn7bnT+iF/0TXxFtocDBuTSqafkAO1DawYXlLKLPYkov1jFeBIc+ W+1rIGlpdyQI1klebpbfQWKzZZmpQ5oKog0ODUYVGwYB48NkqDQ59xuEAwJYaKPzWP8J Wm7AXClTenzeFkMPBvVL3P/OVGht4eMqcrhc1WNhyso3KzTMSZXh7CHAbugREqDiiAT1 Y5iQ== X-Gm-Message-State: AOAM530S2tGu6kIxybqoqd/Yo2uF4B/8p22gF1bN2p78peIeIuKISc9f 7tM1JZl2v2q5ulHmilrg/YxI1w== X-Google-Smtp-Source: ABdhPJzuDFfl+YeXo+oLDAV43WO+1r+i1ImfP2DWcxPkaviwdYfSnI2fhWMMdjGvSkOQ5LWpEaFxOw== X-Received: by 2002:a9d:526:: with SMTP id 35mr1159467otw.176.1623380391091; Thu, 10 Jun 2021 19:59:51 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id 7sm991454oti.30.2021.06.10.19.59.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jun 2021 19:59:50 -0700 (PDT) Date: Thu, 10 Jun 2021 21:59:48 -0500 From: Bjorn Andersson To: Bhupesh Sharma Cc: linux-arm-msm@vger.kernel.org, Linus Walleij , Liam Girdwood , Mark Brown , Vinod Koul , Rob Herring , Andy Gross , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, bhupesh.linux@gmail.com Subject: Re: [PATCH 3/8] dt-bindings: arm: qcom: Add compatible for SA8155p-adp board Message-ID: References: <20210607113840.15435-1-bhupesh.sharma@linaro.org> <20210607113840.15435-4-bhupesh.sharma@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210607113840.15435-4-bhupesh.sharma@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 07 Jun 06:38 CDT 2021, Bhupesh Sharma wrote: > SA8155p-adp board is based on Qualcomm Snapdragon sm8150 > SoC. > > Add support for the same. The SA8155p is similar to SM8150 and we can reuse most things, but I think we can afford to add qcom,sa8155p in the DT bindings. > > Cc: Linus Walleij > Cc: Liam Girdwood > Cc: Mark Brown > Cc: Bjorn Andersson > Cc: Vinod Koul > Cc: Rob Herring > Cc: Andy Gross > Cc: devicetree@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-gpio@vger.kernel.org > Cc: bhupesh.linux@gmail.com > Signed-off-by: Bhupesh Sharma > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > index 9b27e991bddc..b5897f1f9695 100644 > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > @@ -42,11 +42,13 @@ description: | > sdm660 > sdm845 > sdx55 > + sm8150 Naturally sm8150 should be part of this list, but please also add sa8155p as well. > sm8250 > sm8350 > > The 'board' element must be one of the following strings: > > + adp > cdp > cp01-c1 > dragonboard > @@ -198,6 +200,12 @@ properties: > - qcom,ipq6018-cp01-c1 > - const: qcom,ipq6018 > > + - items: > + - enum: > + - qcom,sa8155p-adp > + - qcom,sm8150-mtp > + - const: qcom,sm8150 And please split this in two (one qcom,sm8150-mtp and qcom,sm8150, and one qcom,sa8155p-adp and qcom,sa8155p). And note that this is saying that your compatible needs to be one of the enum entries, followed by the const, but in your dts you only specified qcom,sa8155p-adp. It needs to be: compatible = "qcom,sa8155p-adp", "qcom,sa8155p"; Thanks, Bjorn > + > - items: > - enum: > - qcom,qrb5165-rb5 > -- > 2.31.1 >