From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 829AFC48BE0 for ; Fri, 11 Jun 2021 13:29:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6537D613F4 for ; Fri, 11 Jun 2021 13:29:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230209AbhFKNb0 (ORCPT ); Fri, 11 Jun 2021 09:31:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:36462 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229484AbhFKNbZ (ORCPT ); Fri, 11 Jun 2021 09:31:25 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 68D97613FA; Fri, 11 Jun 2021 13:29:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623418167; bh=5syIn+RCk4Eumnt8SPMfARRletWX4c3GwaWbmkOsZ0U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ww7KB1r+D6dLROk8dlMYpi8iAR+fwNDQlEDSaCPbj5ILCyBZIVmxoxZuhCrKnpvKj 8IDtkwQZd5W6UKgQfJmVQrV21q17wF8pVvEaTtvilYc+1BUFqEt3ecnEdzHqeQS4TL e4fCFA5MiVakh10bIUuEx1haWK3nCHSjqgUsbvn4= Date: Fri, 11 Jun 2021 15:29:24 +0200 From: Greg KH To: Vinod Koul Cc: Jason Gunthorpe , Pierre-Louis Bossart , alsa-devel@alsa-project.org, Leon Romanovsky , linux-kernel@vger.kernel.org, Ranjani Sridharan , hui.wang@canonical.com, Dave Ertman , sanyog.r.kale@intel.com, Bard Liao , rander.wang@linux.intel.com, bard.liao@intel.com Subject: Re: [PATCH v4] soundwire: intel: move to auxiliary bus Message-ID: References: <20210511052132.28150-1-yung-chuan.liao@linux.intel.com> <21002781-0b78-3b36-952f-683482a925d7@linux.intel.com> <07dbe0a2-0abb-810b-ef39-b83511d3f3e0@linux.intel.com> <20210609151022.GF1002214@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 11, 2021 at 04:56:52PM +0530, Vinod Koul wrote: > On 09-06-21, 12:10, Jason Gunthorpe wrote: > > On Wed, Jun 09, 2021 at 09:44:08AM -0500, Pierre-Louis Bossart wrote: > > > > > The consensus for the auxiliary_device model was hard to reach, and the > > > agreement was to align on a minimal model. If you disagree with the > > > directions, you will have to convince Nvidia/Mellanox and Intel networking > > > folks who contributed the solution to do something different. > > > > The purpose of the aux devices was primarily to bind a *software* > > interface between two parts of the kernel. > > Then I dont think this example is valid... This example has a PCI device, > which represents a DSP, HDA controller, DMICs, Soundwire > links... So at least here it is hardware. Yes, and that's fine, and exactly what aux devices were created for. You divide up a single logically addressable device into differently handled portions. Not all hardware specs were as "smart" as USB was in allowing multiple drivers to bind to the same physical USB device and talk to it at the same time :) Luckily the USB spec authors learned from the mistakes of PCI... thanks, greg k-h