linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [syzbot] WARNING in vmk80xx_auto_attach/usb_submit_urb
@ 2021-06-11 20:02 syzbot
  2021-06-12  6:59 ` Greg KH
  0 siblings, 1 reply; 3+ messages in thread
From: syzbot @ 2021-06-11 20:02 UTC (permalink / raw)
  To: gregkh, johan, linux-kernel, linux-usb, mathias.nyman, syzkaller-bugs

Hello,

syzbot found the following issue on:

HEAD commit:    614124be Linux 5.13-rc5
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=12188667d00000
kernel config:  https://syzkaller.appspot.com/x/.config?x=547a5e42ca601229
dashboard link: https://syzkaller.appspot.com/bug?extid=5f29dc6a889fc42bd896
compiler:       Debian clang version 11.0.1-2
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=1687ec3fd00000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=172f44ffd00000

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+5f29dc6a889fc42bd896@syzkaller.appspotmail.com

usb 1-1: New USB device strings: Mfr=0, Product=0, SerialNumber=0
usb 1-1: config 0 descriptor??
------------[ cut here ]------------
usb 1-1: BOGUS urb xfer, pipe 1 != type 3
WARNING: CPU: 1 PID: 20 at drivers/usb/core/urb.c:494 usb_submit_urb+0xacd/0x1550 drivers/usb/core/urb.c:493
Modules linked in:
CPU: 1 PID: 20 Comm: kworker/1:0 Not tainted 5.13.0-rc5-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: usb_hub_wq hub_event
RIP: 0010:usb_submit_urb+0xacd/0x1550 drivers/usb/core/urb.c:493
Code: d8 48 c1 e8 03 42 8a 04 28 84 c0 0f 85 bd 07 00 00 44 8b 03 48 c7 c7 00 8a e1 8a 4c 89 f6 4c 89 fa 89 e9 31 c0 e8 83 d6 8f fb <0f> 0b 4c 8b 74 24 30 45 89 f7 4c 89 ff 48 c7 c6 b0 e1 8d 8d e8 8a
RSP: 0018:ffffc90000da6880 EFLAGS: 00010246
RAX: 0c18ab37a32f8700 RBX: ffffffff8ae18828 RCX: ffff888012c30000
RDX: 0000000000000000 RSI: 0000000080000000 RDI: 0000000000000000
RBP: 0000000000000001 R08: ffffffff81655632 R09: ffffed1017365f90
R10: ffffed1017365f90 R11: 0000000000000000 R12: ffff888022972100
R13: dffffc0000000000 R14: ffffffff8ae22a60 R15: ffff88801da57118
FS:  0000000000000000(0000) GS:ffff8880b9b00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f156613e000 CR3: 0000000018033000 CR4: 00000000001506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 usb_start_wait_urb+0x11a/0x550 drivers/usb/core/message.c:58
 vmk80xx_write_packet drivers/comedi/drivers/vmk80xx.c:213 [inline]
 vmk80xx_reset_device drivers/comedi/drivers/vmk80xx.c:226 [inline]
 vmk80xx_auto_attach+0xcc7/0x22d0 drivers/comedi/drivers/vmk80xx.c:817


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot can test patches for this issue, for details see:
https://goo.gl/tpsmEJ#testing-patches

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [syzbot] WARNING in vmk80xx_auto_attach/usb_submit_urb
  2021-06-11 20:02 [syzbot] WARNING in vmk80xx_auto_attach/usb_submit_urb syzbot
@ 2021-06-12  6:59 ` Greg KH
  2021-06-12 14:19   ` Alan Stern
  0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2021-06-12  6:59 UTC (permalink / raw)
  To: syzbot; +Cc: johan, linux-kernel, linux-usb, mathias.nyman, syzkaller-bugs

On Fri, Jun 11, 2021 at 01:02:23PM -0700, syzbot wrote:
> Hello,
> 
> syzbot found the following issue on:
> 
> HEAD commit:    614124be Linux 5.13-rc5
> git tree:       upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=12188667d00000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=547a5e42ca601229
> dashboard link: https://syzkaller.appspot.com/bug?extid=5f29dc6a889fc42bd896
> compiler:       Debian clang version 11.0.1-2
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=1687ec3fd00000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=172f44ffd00000
> 
> IMPORTANT: if you fix the issue, please add the following tag to the commit:
> Reported-by: syzbot+5f29dc6a889fc42bd896@syzkaller.appspotmail.com
> 
> usb 1-1: New USB device strings: Mfr=0, Product=0, SerialNumber=0
> usb 1-1: config 0 descriptor??
> ------------[ cut here ]------------
> usb 1-1: BOGUS urb xfer, pipe 1 != type 3
> WARNING: CPU: 1 PID: 20 at drivers/usb/core/urb.c:494 usb_submit_urb+0xacd/0x1550 drivers/usb/core/urb.c:493

Looks correct to me, you did not create a valid USB device for the
system to use :)


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [syzbot] WARNING in vmk80xx_auto_attach/usb_submit_urb
  2021-06-12  6:59 ` Greg KH
@ 2021-06-12 14:19   ` Alan Stern
  0 siblings, 0 replies; 3+ messages in thread
From: Alan Stern @ 2021-06-12 14:19 UTC (permalink / raw)
  To: Greg KH
  Cc: syzbot, johan, linux-kernel, linux-usb, mathias.nyman, syzkaller-bugs

On Sat, Jun 12, 2021 at 08:59:26AM +0200, Greg KH wrote:
> On Fri, Jun 11, 2021 at 01:02:23PM -0700, syzbot wrote:
> > Hello,
> > 
> > syzbot found the following issue on:
> > 
> > HEAD commit:    614124be Linux 5.13-rc5
> > git tree:       upstream
> > console output: https://syzkaller.appspot.com/x/log.txt?x=12188667d00000
> > kernel config:  https://syzkaller.appspot.com/x/.config?x=547a5e42ca601229
> > dashboard link: https://syzkaller.appspot.com/bug?extid=5f29dc6a889fc42bd896
> > compiler:       Debian clang version 11.0.1-2
> > syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=1687ec3fd00000
> > C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=172f44ffd00000
> > 
> > IMPORTANT: if you fix the issue, please add the following tag to the commit:
> > Reported-by: syzbot+5f29dc6a889fc42bd896@syzkaller.appspotmail.com
> > 
> > usb 1-1: New USB device strings: Mfr=0, Product=0, SerialNumber=0
> > usb 1-1: config 0 descriptor??
> > ------------[ cut here ]------------
> > usb 1-1: BOGUS urb xfer, pipe 1 != type 3
> > WARNING: CPU: 1 PID: 20 at drivers/usb/core/urb.c:494 usb_submit_urb+0xacd/0x1550 drivers/usb/core/urb.c:493
> 
> Looks correct to me, you did not create a valid USB device for the
> system to use :)

The problem is that vmk80xx_write_packet submits an interrupt URB to 
the ep_tx endpoint, but vmk80xx_find_usb_endpoints will set ep_tx to the 
first OUT endpoint it finds that is either interrupt or bulk.  In this 
case it was bulk, so the driver submitted an interrupt URB to a bulk 
endpoint.

Alan Stern

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-06-12 14:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-11 20:02 [syzbot] WARNING in vmk80xx_auto_attach/usb_submit_urb syzbot
2021-06-12  6:59 ` Greg KH
2021-06-12 14:19   ` Alan Stern

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).