From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0810C48BE8 for ; Mon, 14 Jun 2021 15:30:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9F45C61356 for ; Mon, 14 Jun 2021 15:30:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233903AbhFNPcr (ORCPT ); Mon, 14 Jun 2021 11:32:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234031AbhFNPcU (ORCPT ); Mon, 14 Jun 2021 11:32:20 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73BC6C061787; Mon, 14 Jun 2021 08:29:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=BOAPjwbtdUFJhW0vGZOZuptTrlFMtA9QPhXUlP40eQY=; b=XkpzfRqmBRHXIKnme9t/VjQIKy Zat1XtfRe8V7UJlt6lovmkDrp/eMfRPtb/+QgqmUj125U4i8ZvOeY1iGnrFE0srCupfWZ0n+xDQ8f c0aKSmY8opAMCTNDU0GFm6gD8PpZz62ETmtzFsX6e3QXGaVa1D0MmK7Jc1DXHtK5ANiaSEzNekGWp 2xKx51/J7g0W27PgOqsE1IGKK158UN2CyOQuzGDjN7PBTMA0DmqpO62efsKOg9YXc0xG6mLQ80Yiv c0u4GkVlSZLub+dEctSHP+a2CRKM4X+iyw5zU/gx7THbI5bfNERC+C+HGdEYoj1jDqmAcCfvMZkLf 3PtQfg0Q==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lsoUv-005YqL-2Y; Mon, 14 Jun 2021 15:27:47 +0000 Date: Mon, 14 Jun 2021 16:27:33 +0100 From: Christoph Hellwig To: Max Gurtovoy Cc: Christoph Hellwig , Alex Williamson , Jason Gunthorpe , cohuck@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, aviadye@nvidia.com, oren@nvidia.com, shahafs@nvidia.com, parav@nvidia.com, artemp@nvidia.com, kwankhede@nvidia.com, ACurrid@nvidia.com, cjia@nvidia.com, yishaih@nvidia.com, kevin.tian@intel.com, targupta@nvidia.com, shameerali.kolothum.thodi@huawei.com, liulongfang@huawei.com, yan.y.zhao@intel.com Subject: Re: [PATCH 09/11] PCI: add matching checks for driver_override binding Message-ID: References: <20210603160809.15845-1-mgurtovoy@nvidia.com> <20210603160809.15845-10-mgurtovoy@nvidia.com> <20210608152643.2d3400c1.alex.williamson@redhat.com> <20210608224517.GQ1002214@nvidia.com> <20210608192711.4956cda2.alex.williamson@redhat.com> <117a5e68-d16e-c146-6d37-fcbfe49cb4f8@nvidia.com> <1f7ad5bc-5297-6ddd-9539-a2439f3314fa@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1f7ad5bc-5297-6ddd-9539-a2439f3314fa@nvidia.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 14, 2021 at 11:18:32AM +0300, Max Gurtovoy wrote: > * into a static list of equivalent device types, > * instead of using it as a pointer. > + * @flags: PCI flags of the driver. Bitmap of pci_id_flags enum. > */ > struct pci_device_id { > __u32 vendor, device; /* Vendor and device ID or PCI_ANY_ID*/ > __u32 subvendor, subdevice; /* Subsystem ID's or PCI_ANY_ID */ > __u32 class, class_mask; /* (class,subclass,prog-if) triplet */ > kernel_ulong_t driver_data; /* Data private to the driver */ > + __u32 flags; > }; Isn't struct pci_device_id a userspace ABI due to MODULE_DEVICE_TABLE()?