From: Christoph Hellwig <hch@infradead.org>
To: Claudio Imbrenda <imbrenda@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
linux-s390@vger.kernel.org, frankja@linux.ibm.com,
borntraeger@de.ibm.com, cohuck@redhat.com, david@redhat.com,
linux-mm@kvack.org, Uladzislau Rezki <urezki@gmail.com>,
Nicholas Piggin <npiggin@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
David Rientjes <rientjes@google.com>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH v4 1/2] mm/vmalloc: add vmalloc_no_huge
Date: Mon, 14 Jun 2021 16:21:31 +0100 [thread overview]
Message-ID: <YMdz+xnsUsf3iLeB@infradead.org> (raw)
In-Reply-To: <20210614132357.10202-2-imbrenda@linux.ibm.com>
On Mon, Jun 14, 2021 at 03:23:56PM +0200, Claudio Imbrenda wrote:
> +void *vmalloc_no_huge(unsigned long size)
> +{
> + return __vmalloc_node_range(size, 1, VMALLOC_START, VMALLOC_END, GFP_KERNEL, PAGE_KERNEL,
> + VM_NO_HUGE_VMAP, NUMA_NO_NODE, __builtin_return_address(0));
Please avoid the overly long lines in favor of something actually
human-readable like:
return __vmalloc_node_range(size, 1, VMALLOC_START, VMALLOC_END,
GFP_KERNEL, PAGE_KERNEL, VM_NO_HUGE_VMAP,
NUMA_NO_NODE, __builtin_return_address(0));
next prev parent reply other threads:[~2021-06-14 15:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 13:23 [PATCH v4 0/2] mm: add vmalloc_no_huge and use it Claudio Imbrenda
2021-06-14 13:23 ` [PATCH v4 1/2] mm/vmalloc: add vmalloc_no_huge Claudio Imbrenda
2021-06-14 13:44 ` David Hildenbrand
2021-06-14 13:55 ` Uladzislau Rezki
2021-06-14 15:21 ` Christoph Hellwig [this message]
2021-06-18 19:47 ` David Rientjes
2021-06-14 13:23 ` [PATCH v4 2/2] KVM: s390: prepare for hugepage vmalloc Claudio Imbrenda
2021-06-14 13:44 ` David Hildenbrand
2021-06-14 23:59 ` [PATCH v4 0/2] mm: add vmalloc_no_huge and use it Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMdz+xnsUsf3iLeB@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=borntraeger@de.ibm.com \
--cc=catalin.marinas@arm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=npiggin@gmail.com \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).