From: Al Viro <viro@zeniv.linux.org.uk>
To: Kees Cook <keescook@chromium.org>
Cc: Christoph Hellwig <hch@lst.de>,
WeiXiong Liao <gmpy.liaowx@gmail.com>,
axboe@kernel.dk, Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] pstore/blk: Use the normal block device I/O path
Date: Mon, 14 Jun 2021 20:09:30 +0000 [thread overview]
Message-ID: <YMe3eoodEyT+r1oI@zeniv-ca.linux.org.uk> (raw)
In-Reply-To: <20210614200421.2702002-1-keescook@chromium.org>
On Mon, Jun 14, 2021 at 01:04:21PM -0700, Kees Cook wrote:
> static ssize_t psblk_generic_blk_write(const char *buf, size_t bytes,
> loff_t pos)
> {
> /* Console/Ftrace backend may handle buffer until flush dirty zones */
> if (in_interrupt() || irqs_disabled())
> return -EBUSY;
> + return kernel_write(psblk_file, buf, bytes, &pos);
In which locking environments could that be called? The checks above
look like that thing could be called from just about any context;
could that happen when the caller is holding a page locked?
IOW, what are those checks really trying to do?
next prev parent reply other threads:[~2021-06-14 20:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 20:04 [PATCH] pstore/blk: Use the normal block device I/O path Kees Cook
2021-06-14 20:09 ` Al Viro [this message]
2021-06-14 21:46 ` Kees Cook
2021-06-15 12:31 ` Christoph Hellwig
2021-06-15 16:04 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMe3eoodEyT+r1oI@zeniv-ca.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=anton@enomsg.org \
--cc=axboe@kernel.dk \
--cc=ccross@android.com \
--cc=gmpy.liaowx@gmail.com \
--cc=hch@lst.de \
--cc=keescook@chromium.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).