From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 069DFC48BE8 for ; Mon, 14 Jun 2021 16:29:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CF21A61378 for ; Mon, 14 Jun 2021 16:29:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234709AbhFNQbs (ORCPT ); Mon, 14 Jun 2021 12:31:48 -0400 Received: from mail-ot1-f49.google.com ([209.85.210.49]:36799 "EHLO mail-ot1-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234620AbhFNQbr (ORCPT ); Mon, 14 Jun 2021 12:31:47 -0400 Received: by mail-ot1-f49.google.com with SMTP id h24-20020a9d64180000b029036edcf8f9a6so11388683otl.3 for ; Mon, 14 Jun 2021 09:29:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=9CIY8AjuCRy8RieSStx5nb9rNTU57wmjgQb3HVjK27U=; b=i663WzaVYh9vcq7ceJqDlWbmey3o6O+WEhi7etvgrLnxsxi8f9kgk9mEDBtlC4Piyy 7LteFPw1qcz5tkTdJK6vZi1eGrQ91DeQPPH4DWVoTFJ7lipp6uuWFs04mr4qJYjZkhC8 fDaF0llrx66733fzl44DMSzDRNRjYyaPVXt+hEmldEFM/I3fzU0FgcGx2g3i0dp8hdlb Rd7qiOi8MEDfHAuuDyRhwywrohKyktaISRVuR1BVp3URCDxR6LUex6I09mb3eVb2rh0L UUWgIKKRnYlVihuCna31RI/TsnF0ger4VBYtMDUjeRv0o6Urogy4ogDh+m8jnO3swO+3 t4Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9CIY8AjuCRy8RieSStx5nb9rNTU57wmjgQb3HVjK27U=; b=YmLljjngGx4Cst5/oGxGZaJbSkCGV8wBBngLvgtK7b8FVuLePMLkWVznChrnZ0y0E4 2R9zeWIpo8VpN7z2ZYIbxedCnU+sPsAhCqSKpHbshxhq8+DHH6FODBqFT1JaxpEL++QY e1JDxPBbRvSqcW3vgOTESx5/W7PSbjfGMVRqqWjjrMRkpl/4Y1ItSjfivDV5mE7YINVC lStc2vphwtjKl9/op4EvdCivRhtJ/G/0XeJhftLVw2dYZoc/XbP8qTg1lpqCqmZvbflp NVeHnWhQEXuEwBRzFhrgtFWm7Ap8X6Ih5bbygbvXRcKoFRDLU91ZArtR2WKKX+xgT4Iq FInA== X-Gm-Message-State: AOAM533IhAmJ+Ux0qk5xN4bdl8W4tEBoDRhOSxosA7NE2S3/McdV4kFo 3GNjDRDhXA5VLIo+x/F9G7jWZw== X-Google-Smtp-Source: ABdhPJwIXsrftnZxjGMjBdTiMtowSy+ltDxlxiwm7UMHVPBGyAbeWkXvt8Fplt0tpJ3QCoiJRkhHYg== X-Received: by 2002:a9d:491:: with SMTP id 17mr14139894otm.184.1623688124306; Mon, 14 Jun 2021 09:28:44 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id w186sm3058210oib.58.2021.06.14.09.28.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jun 2021 09:28:43 -0700 (PDT) Date: Mon, 14 Jun 2021 11:28:41 -0500 From: Bjorn Andersson To: Bhupesh Sharma Cc: linux-arm-msm@vger.kernel.org, Linus Walleij , Liam Girdwood , Mark Brown , Vinod Koul , Rob Herring , Andy Gross , devicetree , Linux Kernel Mailing List , "open list:GPIO SUBSYSTEM" , bhupesh.linux@gmail.com Subject: Re: [PATCH 1/8] dt-bindings: qcom: rpmh-regulator: Add compatible for SA8155p-adp board pmics Message-ID: References: <20210607113840.15435-1-bhupesh.sharma@linaro.org> <20210607113840.15435-2-bhupesh.sharma@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 14 Jun 03:05 CDT 2021, Bhupesh Sharma wrote: > Hello Bjorn, > > Thanks for the review comments. > > On Fri, 11 Jun 2021 at 08:18, Bjorn Andersson > wrote: > > > > On Mon 07 Jun 06:38 CDT 2021, Bhupesh Sharma wrote: > > > > > Add compatible strings for pmm8155au_1 and pmm8155au_2 pmics > > > found on SA8155p-adp board. > > > > > > Cc: Linus Walleij > > > Cc: Liam Girdwood > > > Cc: Mark Brown > > > Cc: Bjorn Andersson > > > Cc: Vinod Koul > > > Cc: Rob Herring > > > Cc: Andy Gross > > > Cc: devicetree@vger.kernel.org > > > Cc: linux-kernel@vger.kernel.org > > > Cc: linux-gpio@vger.kernel.org > > > Cc: bhupesh.linux@gmail.com > > > Signed-off-by: Bhupesh Sharma > > > --- > > > .../devicetree/bindings/regulator/qcom,rpmh-regulator.yaml | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml > > > index e561a5b941e4..ea5cd71aa0c7 100644 > > > --- a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml > > > +++ b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml > > > @@ -55,6 +55,8 @@ properties: > > > - qcom,pm8009-1-rpmh-regulators > > > - qcom,pm8150-rpmh-regulators > > > - qcom,pm8150l-rpmh-regulators > > > + - qcom,pmm8155au-1-rpmh-regulators > > > + - qcom,pmm8155au-2-rpmh-regulators > > > > Looking at the component documentation and the schematics I think the > > component is "PMM8155AU" and we have two of them. > > > > Unless I'm mistaken we should have the compatible describe the single > > component and we should have DT describe the fact that we have 2 of > > them. > > If we refer to the PM8155AU device specifications, there are two > regulators mentioned there PMM8155AU_1 and PMM8155AU_2. Although most > parameters of the regulators seem similar the smps regulator summary > for both appear different (Transient Load, mA ratings etc). > > Although most of these differences don't probably matter to the Linux > world, others like the gpios on the pmic are different. > > So, IMO, it makes sense to mention the different pmic types on the board. > > Please let me know your views on the same. > Afaict, they are both physically the same component, but there is some configuration differences between them. I don't see any differences that will show up in Linux, but afaict we would capture those in the DT anyways. Let me know if you see anything I'm missing, but I think we should have a single compatible. Regards, Bjorn > Thanks, > Bhupesh > > > > > > - qcom,pm8350-rpmh-regulators > > > - qcom,pm8350c-rpmh-regulators > > > - qcom,pm8998-rpmh-regulators > > > -- > > > 2.31.1 > > >