From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0FA5C4743C for ; Mon, 14 Jun 2021 16:59:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7D96C611CA for ; Mon, 14 Jun 2021 16:59:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234588AbhFNRBR (ORCPT ); Mon, 14 Jun 2021 13:01:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233206AbhFNRBP (ORCPT ); Mon, 14 Jun 2021 13:01:15 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD52EC061574; Mon, 14 Jun 2021 09:59:11 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 681D3A59; Mon, 14 Jun 2021 18:59:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1623689949; bh=TTzEHwOuhgSM39sroCCujZmwX9sHOPc/YKGwgSdMLOw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TXA1lrj7Ogj8VCiIJkQWIZ0+cVLqkwICv4YBmxgUJ1deC6tg7jESEKsWPIa4Ro85f fCFiZZWVcoYY3MmGjHFADEbCgDddU6WBZwdAp/vXKzGMrJA8R2GJGzSsx+Mt7ySzmG Q0DJlIp53YGMYykmlAB9pPwqgZcD/+mjb6CO486U= Date: Mon, 14 Jun 2021 19:58:49 +0300 From: Laurent Pinchart To: Arnd Bergmann Cc: Hans Verkuil , Mauro Carvalho Chehab , Arnd Bergmann , "Lad, Prabhakar" , Eduardo Valentin , Sakari Ailus , Greg Kroah-Hartman , Vaibhav Gupta , Liu Shixin , Jacopo Mondi , Andy Shevchenko , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH v3 3/8] media: v4l2-core: fix whitespace damage in video_get_user() Message-ID: References: <20210614103409.3154127-1-arnd@kernel.org> <20210614103409.3154127-4-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210614103409.3154127-4-arnd@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, Thank you for the patch. On Mon, Jun 14, 2021 at 12:34:04PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > The initialization was indented with an extra tab in most lines, > remove them to get the normal coding style. > > Signed-off-by: Arnd Bergmann Reviewed-by: Laurent Pinchart > --- > drivers/media/v4l2-core/v4l2-ioctl.c | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c > index f19e56116e53..d94389145479 100644 > --- a/drivers/media/v4l2-core/v4l2-ioctl.c > +++ b/drivers/media/v4l2-core/v4l2-ioctl.c > @@ -3142,18 +3142,18 @@ static int video_get_user(void __user *arg, void *parg, > > *vb = (struct v4l2_buffer) { > .index = vb32.index, > - .type = vb32.type, > - .bytesused = vb32.bytesused, > - .flags = vb32.flags, > - .field = vb32.field, > - .timestamp.tv_sec = vb32.timestamp.tv_sec, > - .timestamp.tv_usec = vb32.timestamp.tv_usec, > - .timecode = vb32.timecode, > - .sequence = vb32.sequence, > - .memory = vb32.memory, > - .m.userptr = vb32.m.userptr, > - .length = vb32.length, > - .request_fd = vb32.request_fd, > + .type = vb32.type, > + .bytesused = vb32.bytesused, > + .flags = vb32.flags, > + .field = vb32.field, > + .timestamp.tv_sec = vb32.timestamp.tv_sec, > + .timestamp.tv_usec = vb32.timestamp.tv_usec, > + .timecode = vb32.timecode, > + .sequence = vb32.sequence, > + .memory = vb32.memory, > + .m.userptr = vb32.m.userptr, > + .length = vb32.length, > + .request_fd = vb32.request_fd, > }; > break; > } -- Regards, Laurent Pinchart