From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 452F5C2B9F4 for ; Mon, 14 Jun 2021 20:59:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C910601FC for ; Mon, 14 Jun 2021 20:59:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234900AbhFNVBW (ORCPT ); Mon, 14 Jun 2021 17:01:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234749AbhFNVBU (ORCPT ); Mon, 14 Jun 2021 17:01:20 -0400 Received: from mail-oi1-x232.google.com (mail-oi1-x232.google.com [IPv6:2607:f8b0:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 691FBC061767 for ; Mon, 14 Jun 2021 13:59:17 -0700 (PDT) Received: by mail-oi1-x232.google.com with SMTP id a26so15746043oie.11 for ; Mon, 14 Jun 2021 13:59:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=/6pKbYj2ed0f0UaEFoaaIUYpFQjvxwrfEa8r7ccecLg=; b=VUcpHcO5+69x+UmFhBX81AvNnV4yZG99MUIPNECFwsScWTK9TaiV0hoCkGfUU7392i IdO3v0bqNtQ1pwOSOr5vbmkySR/9FlzDmozXlGeRfxcECdSsPUtEdGP3mmVqo+gbFuSx I/hgEmF4rADrAYt7llABIPizW00BM03GI/jxEkEFQMC+ceuxqkSY3x0i97Kt4IXrHsd4 i7QlXM1QDPv+NcO410O/yjq72NZY5qV2iCblFogQg9l3bPUMsde5DdeS/BiL7PNGRux8 woxP/GxKqD7irINk0gd14N5PWdLSw9pnWtKhqYVsYiQzD1BvT2DSP5aLiqSVf7hdMCDs yR7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/6pKbYj2ed0f0UaEFoaaIUYpFQjvxwrfEa8r7ccecLg=; b=iZPM0vjhGB2HjeSwKHdkZaGph5eQALdCcfxee054JAZW6zGxrvqF+r3U4w30U96c9T zsAYxGxRBvPPVueHOOuUiMLjDGd5neTkX7PS1ERZNYzXI4juqbL2v+QDVyoQ7o2Ra1V9 alzl6C3uNkLJba85CpSA4wbXrbD7KVyVlDvcI7PgIsb95co4vR3t4ByX6Y+me11mH16q x9sam/YS347l0j6K/0Ig3i0lJigZ/HLL9YUkmLg6pb+3vNfrOWvyU60k6yX0Fg9ZMHjm YJ1i2QWh+MG7f9dlu7Mc58iNa6AV319uYU/dtNmg5jj+rd1kb3hg97yVGt6Qoet0N2s7 Fdrg== X-Gm-Message-State: AOAM5312UavTBFd9ujxdtujq5Ne8gZQY4UQlYdawuoAOH57p+2eA6uI2 2wO6sQGCaC9zzykxnBVHNwtUgA== X-Google-Smtp-Source: ABdhPJyGwTQzDPCtsM1dRKOQR3lJJwgBKHzl/HwiNMhRIvnaoQC31Qzw/GHpYHI9LCZcyYFGlq/1kg== X-Received: by 2002:a05:6808:352:: with SMTP id j18mr672718oie.122.1623704356727; Mon, 14 Jun 2021 13:59:16 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id h1sm3583245otq.59.2021.06.14.13.59.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jun 2021 13:59:16 -0700 (PDT) Date: Mon, 14 Jun 2021 15:59:14 -0500 From: Bjorn Andersson To: Siddharth Gupta Cc: ohad@wizery.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, psodagud@codeaurora.org, stable@vger.kernel.org Subject: Re: [PATCH v2 0/4] remoteproc: core: Fixes for rproc cdev and add Message-ID: References: <1623703244-26814-1-git-send-email-sidgup@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1623703244-26814-1-git-send-email-sidgup@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 14 Jun 15:40 CDT 2021, Siddharth Gupta wrote: > This patch series contains stability fixes and error handling for remoteproc. > Thanks for respinning this Sid, I think patch 3 looks good now as well, but it seems you accidentally got an additional file in the same patch. Can you please fix that up and resend the patches? Regards, Bjorn > The changes included in this series do the following: > Patch 1: Fixes the creation of the rproc character device. > Patch 2: Validates rproc as the first step of rproc_add(). > Patch 3: Fixes the rproc cdev remove and the order of dev_del() and cdev_del(). > Patch 4: Adds error handling in rproc_add(). > > v1 -> v2: > - Added extra patch which addresses Bjorn's comments on patch 3 > from v1. > - Fixed commit text for patch 2 (s/calling making/making). > > Siddharth Gupta (4): > remoteproc: core: Move cdev add before device add > remoteproc: core: Move validate before device add > remoteproc: core: Fix cdev remove and rproc del > remoteproc: core: Cleanup device in case of failure > > 0000-cover-letter.patch.backup | 26 ++++++++++++++++++++++++++ > drivers/remoteproc/remoteproc_cdev.c | 2 +- > drivers/remoteproc/remoteproc_core.c | 27 ++++++++++++++++++--------- > 3 files changed, 45 insertions(+), 10 deletions(-) > create mode 100644 0000-cover-letter.patch.backup > > -- > Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >