From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A6DEC49EA2 for ; Tue, 15 Jun 2021 04:54:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 06E72613DA for ; Tue, 15 Jun 2021 04:54:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230064AbhFOE4V (ORCPT ); Tue, 15 Jun 2021 00:56:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:48028 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229968AbhFOE4U (ORCPT ); Tue, 15 Jun 2021 00:56:20 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2F8736140C; Tue, 15 Jun 2021 04:54:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623732855; bh=Hy47A6sDeDK5g7Q5O8jSY970MU9+ZwCkDct4y1d2MOQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c5luMNlXN45gsnjoT7ZAEHeSo4zvFcWP9bbHYPHa2DXxgXuwPtyM+U/2Oawme604d QCsuyDD/R9ZHrHa66qMInzV4pFn0ia7wc2Q5fOejGauo5+FoDRWgONUTfJWFmi4Bhr FB5C3UysQ1jKKZABMCKKcgh4gkX2frG+MQkR/tdM= Date: Tue, 15 Jun 2021 06:54:12 +0200 From: Greg KH To: Siddharth Gupta Cc: bjorn.andersson@linaro.org, ohad@wizery.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, psodagud@codeaurora.org, stable@vger.kernel.org Subject: Re: [PATCH v3 2/4] remoteproc: core: Move validate before device add Message-ID: References: <1623723671-5517-1-git-send-email-sidgup@codeaurora.org> <1623723671-5517-3-git-send-email-sidgup@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1623723671-5517-3-git-send-email-sidgup@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 14, 2021 at 07:21:09PM -0700, Siddharth Gupta wrote: > We can validate whether the remoteproc is correctly setup before > making the cdev_add and device_add calls. This saves us the > trouble of cleaning up later on. > > Signed-off-by: Siddharth Gupta > Reviewed-by: Bjorn Andersson > --- > drivers/remoteproc/remoteproc_core.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.