From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alex Nemirovsky <Alex.Nemirovsky@cortina-access.com>
Cc: Jason Li <jason.li@cortina-access.com>,
Rob Herring <robh+dt@kernel.org>, Rob Herring <robh@kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 2/3] dt-bindings: serial: Convert Cortina-Access UART to json-schema
Date: Tue, 15 Jun 2021 17:40:50 +0200 [thread overview]
Message-ID: <YMjKAhP19Q53jsnC@kroah.com> (raw)
In-Reply-To: <B71C5D02-EDBE-4AAD-AF1B-2FD467BE075A@cortina-access.com>
On Tue, Jun 15, 2021 at 02:39:08PM +0000, Alex Nemirovsky wrote:
>
>
> > On Jun 15, 2021, at 7:13 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> >
> > On Tue, Jun 15, 2021 at 01:36:39PM +0000, Alex Nemirovsky wrote:
> >> MAINTAINERS modification was made in the initial version 1. We made no changes to it since then,
> >> thus not sure what we could at to Changelog which would add value or clarity for others
> >> from the v1.
> >>
> >>> On Jun 15, 2021, at 4:53 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> >>>
> >>> On Sun, May 09, 2021 at 11:45:17AM -0700, Alex Nemirovsky wrote:
> >>>> From: Jason Li <jason.li@cortina-access.com>
> >>>>
> >>>> Convert the Cortina-Access UART binding to DT schema format.
> >>>>
> >>>> Signed-off-by: Jason Li <jason.li@cortina-access.com>
> >>>> ---
> >>>> .../serial/cortina-access,serial.yaml | 46 +++++++++++++++++++
> >>>> .../devicetree/bindings/vendor-prefixes.yaml | 2 +
> >>>> MAINTAINERS | 6 +++
> >>>
> >>> You are also adding a MAINTAINERS entry here, which is not listed in the
> >>> changelog text, so I couldn't take it anyway :(
> >
> > Add the maintainers entry in the first patch, with the driver please.
>
> The change to MAINTAINERS here add a new file into the DT documentation.
> Should it not be grouped into the dt-binding portion and reviewed by the DT time for which this patch
> is CC’ed to? Why would moving the DT documentation file that is introduced be into the first patch, which is the
> serial driver itself be the correct approach?
Add it as a stand-alone patch at the end of the series, that just adds
the MAINTAINERS entry.
thanks,
greg k-h
next prev parent reply other threads:[~2021-06-15 15:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210509184519.15816-1-alex.nemirovsky@cortina-access.com>
2021-06-15 11:52 ` [PATCH v4 1/3] tty: serial: Add UART driver for Cortina-Access platform Greg Kroah-Hartman
2021-06-15 13:32 ` Alex Nemirovsky
2021-06-15 14:13 ` Greg Kroah-Hartman
2021-06-15 14:33 ` Alex Nemirovsky
2021-06-15 15:40 ` Greg Kroah-Hartman
2021-06-15 16:01 ` Alex Nemirovsky
[not found] ` <20210509184519.15816-2-alex.nemirovsky@cortina-access.com>
2021-06-15 11:53 ` [PATCH v4 2/3] dt-bindings: serial: Convert Cortina-Access UART to json-schema Greg Kroah-Hartman
2021-06-15 13:36 ` Alex Nemirovsky
2021-06-15 14:13 ` Greg Kroah-Hartman
2021-06-15 14:39 ` Alex Nemirovsky
2021-06-15 15:40 ` Greg Kroah-Hartman [this message]
2021-06-15 15:44 ` Rob Herring
2021-06-15 16:06 ` Alex Nemirovsky
2021-06-15 16:20 ` Rob Herring
2021-06-22 11:28 ` Geert Uytterhoeven
2021-06-22 14:20 ` Alex Nemirovsky
2021-06-22 15:18 ` Arnd Bergmann
2021-06-24 12:46 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMjKAhP19Q53jsnC@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Alex.Nemirovsky@cortina-access.com \
--cc=devicetree@vger.kernel.org \
--cc=jason.li@cortina-access.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).