linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Cc: linux-kernel@vger.kernel.org,
	Dan Carpenter <dan.carpenter@oracle.com>,
	Johannes Thumshirn <jth@kernel.org>
Subject: Re: [PATCH 2/3] mcb: fix error handling in mcb_alloc_bus()
Date: Tue, 15 Jun 2021 17:41:54 +0200	[thread overview]
Message-ID: <YMjKQnFRi0feSYiI@kroah.com> (raw)
In-Reply-To: <b2fa90594069aa3f61d4658603d922f097ce2bde.1623768541.git.johannes.thumshirn@wdc.com>

On Tue, Jun 15, 2021 at 11:55:29PM +0900, Johannes Thumshirn wrote:
> From: Dan Carpenter <dan.carpenter@oracle.com>
> 
> There are two bugs:
> 1) If ida_simple_get() fails then this code calls put_device(carrier)
>    but we haven't yet called get_device(carrier) and probably that
>    leads to a use after free.
> 2) After device_initialize() then we need to use put_device() to
>    release the bus.  This will free the internal resources tied to the
>    device and call mcb_free_bus() which will free the rest.
> 
> Fixes: 5d9e2ab9fea4 ("mcb: Implement bus->dev.release callback")
> Fixes: 18d288198099 ("mcb: Correctly initialize the bus's device")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Johannes Thumshirn <jth@kernel.org>
> ---
>  drivers/mcb/mcb-core.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

Shouldn't this go to the stable kernels?  Why not cc: stable in the
signed-off-by lines?

thanks,

greg k-h

  reply	other threads:[~2021-06-15 15:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-15 14:55 [PATCH 0/3] mcb changes for 5.14 Johannes Thumshirn
2021-06-15 14:55 ` [PATCH 1/3] mcb: Use DEFINE_RES_MEM() to simplify code Johannes Thumshirn
2021-06-15 15:42   ` Greg Kroah-Hartman
2021-06-16  1:31     ` Leizhen (ThunderTown)
2021-06-16  6:41       ` Greg Kroah-Hartman
2021-06-15 14:55 ` [PATCH 2/3] mcb: fix error handling in mcb_alloc_bus() Johannes Thumshirn
2021-06-15 15:41   ` Greg Kroah-Hartman [this message]
2021-06-15 15:44     ` Johannes Thumshirn
2021-06-15 14:55 ` [PATCH 3/3] mcb: Remove trailing semicolon in macros Johannes Thumshirn
2021-06-15 15:48   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YMjKQnFRi0feSYiI@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dan.carpenter@oracle.com \
    --cc=johannes.thumshirn@wdc.com \
    --cc=jth@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).