From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91DDBC48BE5 for ; Wed, 16 Jun 2021 00:00:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 645346137D for ; Wed, 16 Jun 2021 00:00:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231636AbhFPACl (ORCPT ); Tue, 15 Jun 2021 20:02:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229811AbhFPACk (ORCPT ); Tue, 15 Jun 2021 20:02:40 -0400 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18C96C061574 for ; Tue, 15 Jun 2021 17:00:35 -0700 (PDT) Received: by mail-wm1-x330.google.com with SMTP id l7-20020a05600c1d07b02901b0e2ebd6deso595776wms.1 for ; Tue, 15 Jun 2021 17:00:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Cavx6x3nhYXx5BnoO8glUCwT6RHhCwAb/VYzJ1vZ0Uo=; b=Pab3Zzxhu/tOKYzmcCnj0QqXTXH6fu4+7hf+f+cxFUFlbtNZTAVDuNr7sXGYalOAZH Aiac7+ZJjlISiIVcD7suOALI1LEMr3f2RhAtPJ2p7XlUfaAddPC93sjUNbMx4ckq3y0t HSVWKOYqeCxPyZbkf4idv1UsuhbpxGsSGMCmo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Cavx6x3nhYXx5BnoO8glUCwT6RHhCwAb/VYzJ1vZ0Uo=; b=PxhyJGQZYP5CqgHQobqWaDLTAJSS8E3bpAslKjr5fBCmEvmygGP5TsvElKXLjKLzMM JnWwJ5s2vjJqqQBYtBr6O/NbHb2SnxF9M5VENUzu6+sg9ZSwh5jcDqnefbJ0AivSZiMp 7TkWNrAWbrxMXFcLSOr0rUyTkXlRUgmUi9S6zhrb3xqk/CUJhBQFmvblFi7RJE5g7VgJ 3Cxtgzvre8Q7CKQAr9GaEf81pp1EpTkmNaxozRbpwh2gn0okyTL0zhVZblgFX8Ch3lxR 13qrqfkaHIQ4gPYGKPdVpN7djEb5X3sQbMYaIKnWeBCm6Vne3afubPepXb9K4zmKhcdJ reBQ== X-Gm-Message-State: AOAM5332mRVqzYNkksfEwmeq1Dng4dsu1rIWNkQbdQjZ1EdaNlIuMoaw yUdFZlMIKunJJR0meTaah6ZwLA== X-Google-Smtp-Source: ABdhPJxTbX2f33fgYdd6RIbF7XV0MAabctYxu0RyqDuOQTKQPB46xOyE13DceU2g6tMhcKdV4XHHTw== X-Received: by 2002:a05:600c:2284:: with SMTP id 4mr1930697wmf.146.1623801633607; Tue, 15 Jun 2021 17:00:33 -0700 (PDT) Received: from localhost ([2620:10d:c093:400::5:db96]) by smtp.gmail.com with ESMTPSA id g10sm363204wrq.12.2021.06.15.17.00.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jun 2021 17:00:33 -0700 (PDT) Date: Wed, 16 Jun 2021 01:00:32 +0100 From: Chris Down To: Andy Shevchenko Cc: Linux Kernel Mailing List , Petr Mladek , Jessica Yu , Sergey Senozhatsky , John Ogness , Steven Rostedt , Greg Kroah-Hartman , Johannes Weiner , Kees Cook , Andy Shevchenko , Rasmus Villemoes , kernel-team@fb.com Subject: Re: [PATCH v7 1/5] string_helpers: Escape double quotes in escape_special Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.1 (4b100969) (2021-06-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andy Shevchenko writes: >> I've checked uses of ESCAPE_SPECIAL and %pE across the codebase, and I'm > >checked the uses Hmm, what's wrong with using the zero article for "checked uses"? I mean, I don't have any strong resistance, but I don't see anything wrong with it either, and it matches how I'd naturally speak. Agreed on the others, though, hopefully they can be massaged in :-)